Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-12-07 21:59:54 +00:00
Code Issues Projects Releases Packages Wiki Activity

LibWeb/DOM: Stop adding duplicates to the agent's signal_slots

Browse source 
We use a Vector for this, but its spec definition is an ordered set.
That means we need to ensure we don't add duplicates. This fixes issues
where we would send slotchange events multiple times to the same
HTMLSlotElement.
This commit is contained in:
Sam Atkins 2025-11-21 13:48:43 +00:00 • committed by Andreas Kling
parent 6e17503423
commit e691f0e10f
Notes: github-actions[bot] 2025-11-21 15:21:07 +00:00
2 changed files with 21 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Libraries/LibWeb/DOM/Slottable.cpp
View file

@ -256,7 +256,10 @@ void assign_a_slot(Slottable const& slottable)
void signal_a_slot_change(GC::Ref<HTML::HTMLSlotElement> slottable)
{
// 1. Append slot to slot’s relevant agent’s signal slots.
HTML::relevant_similar_origin_window_agent(slottable).signal_slots.append(slottable);
// NB: signal_slots is supposed to be a set, so ensure the slottable is not already there.
auto& signal_slots = HTML::relevant_similar_origin_window_agent(slottable).signal_slots;
if (!signal_slots.contains_slow(slottable))
signal_slots.append(slottable);
// 2. Queue a mutation observer microtask.
Bindings::queue_mutation_observer_microtask(slottable->document());