Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-12-07 21:59:54 +00:00
Code Issues Projects Releases Packages Wiki Activity

LibWeb: Avoid full DOM tree traversal in supported_property_names()

Browse source 
Instead, take advantage of `ElementByIdMap` and
`m_potentially_named_elements` to gather named elements more
efficiently.
This commit is contained in:
Aliaksandr Kalenik 2025-11-24 20:35:06 +01:00 • committed by Jelle Raaijmakers
parent 5fa3b48a57
commit e80d1bcee7
Notes: github-actions[bot] 2025-11-25 08:17:41 +00:00
2 changed files with 13 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Libraries/LibWeb/DOM/ElementByIdMap.h
View file

@ -17,6 +17,13 @@ public:
void remove(FlyString const& element_id, Element&);
GC::Ptr<Element> get(FlyString const& element_id) const;
template<typename Callback>
void for_each_id(Callback callback)
{
for (auto const& id : m_map.keys())
callback(id);
}
private:
HashMap<FlyString, Vector<GC::Weak<Element>>> m_map;
};

14
Libraries/LibWeb/HTML/Window.cpp
View file

@ -1826,14 +1826,12 @@ Vector<FlyString> Window::supported_property_names() const
// that have a non-empty name content attribute and are in a document tree with window's associated Document as their root; and
// - the value of the id content attribute for all HTML elements that have a non-empty id content attribute
// and are in a document tree with window's associated Document as their root.
associated_document().for_each_in_subtree_of_type<DOM::Element>([&property_names](auto& element) -> TraversalDecision {
if (is<HTMLEmbedElement>(element) || is<HTMLFormElement>(element) || is<HTMLImageElement>(element) || is<HTMLObjectElement>(element)) {
if (element.name().has_value())
property_names.set(element.name().value(), AK::HashSetExistingEntryBehavior::Keep);
}
if (auto const& name = element.id(); name.has_value())
property_names.set(name.value().to_string(), AK::HashSetExistingEntryBehavior::Keep);
return TraversalDecision::Continue;
for (auto element : associated_document().potentially_named_elements()) {
if (auto name = element->name(); name.has_value())
property_names.set(*name, AK::HashSetExistingEntryBehavior::Keep);
}
associated_document().element_by_id().for_each_id([&](auto id) {
property_names.set(id, AK::HashSetExistingEntryBehavior::Keep);
});
return property_names.values();