Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-12-08 06:09:58 +00:00
Code Issues Projects Releases Packages Wiki Activity

LibJS: Do not verify cycle root's status is linked in CyclicModule

Browse source 
This VERIFY is both incorrect and redundant. The VERIFY at step 2
verifies the status when evaluate is called on m_cycle_root.
This commit is contained in:
caztanj 2025-09-10 19:24:11 +02:00 • committed by Jelle Raaijmakers
parent 61c36e2865
commit e93f44112d
Notes: github-actions[bot] 2025-10-22 09:56:02 +00:00
5 changed files with 15 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Libraries/LibJS/CyclicModule.cpp
View file

@ -344,7 +344,6 @@ ThrowCompletionOr<GC::Ref<Promise>> CyclicModule::evaluate(VM& vm)
if ((m_status == ModuleStatus::EvaluatingAsync || m_status == ModuleStatus::Evaluated) && m_cycle_root != this) {
// Note: This will continue this function with module.[[CycleRoot]]
VERIFY(m_cycle_root);
VERIFY(m_cycle_root->m_status == ModuleStatus::Linked);
dbgln_if(JS_MODULE_DEBUG, "[JS MODULE] evaluate[{}](vm) deferring to cycle root at {}", this, m_cycle_root.ptr());
return m_cycle_root->evaluate(vm);
}