From e9519b132fffab70b5d7e66cadd225f5890ef20f Mon Sep 17 00:00:00 2001
From: Tim Ledbetter <tim.ledbetter@ladybird.org>
Date: Fri, 7 Nov 2025 12:19:42 +0000
Subject: [PATCH] Base: Use the correct memory unit suffixes in
 `about::processes`

Previously the GB suffix was displayed as BB.
---
 Base/res/ladybird/about-pages/processes.html  | 22 +++++----
 .../ladybird/about-pages/settings/privacy.js  | 45 +++++--------------
 Base/res/ladybird/utils.js                    | 32 +++++++++++++
 UI/cmake/ResourceFiles.cmake                  |  1 +
 4 files changed, 54 insertions(+), 46 deletions(-)
 create mode 100644 Base/res/ladybird/utils.js

diff --git a/Base/res/ladybird/about-pages/processes.html b/Base/res/ladybird/about-pages/processes.html
index b311178d856..7ef93cca202 100644
--- a/Base/res/ladybird/about-pages/processes.html
+++ b/Base/res/ladybird/about-pages/processes.html
@@ -76,22 +76,20 @@
             </thead>
             <tbody id="process-table"></tbody>
         </table>
-
-        <script type="text/javascript">
+        <script type="module">
+            import { getByteFormatter }  from "resource://ladybird/utils.js";
+            const memoryFormatter = getByteFormatter(() => {
+                return {
+                    unitDisplay: "narrow",
+                    minimumFractionDigits: 2,
+                    maximumFractionDigits: 2,
+                }
+            })
             const cpuFormatter = new Intl.NumberFormat([], {
                 minimumFractionDigits: 2,
                 maximumFractionDigits: 2,
             });
 
-            const memoryFormatter = new Intl.NumberFormat([], {
-                style: "unit",
-                unit: "byte",
-                notation: "compact",
-                unitDisplay: "narrow",
-                minimumFractionDigits: 2,
-                maximumFractionDigits: 2,
-            });
-
             const Direction = Object.freeze({
                 ascending: 1,
                 descending: 2,
@@ -141,7 +139,7 @@
                     insertColumn(row, process.name);
                     insertColumn(row, process.pid);
                     insertColumn(row, cpuFormatter.format(process.cpu));
-                    insertColumn(row, memoryFormatter.format(process.memory));
+                    insertColumn(row, memoryFormatter.formatBytes(process.memory));
                 });
 
                 oldTable.parentNode.replaceChild(newTable, oldTable);
diff --git a/Base/res/ladybird/about-pages/settings/privacy.js b/Base/res/ladybird/about-pages/settings/privacy.js
index b1f9e1db153..23cd06d5e19 100644
--- a/Base/res/ladybird/about-pages/settings/privacy.js
+++ b/Base/res/ladybird/about-pages/settings/privacy.js
@@ -1,3 +1,11 @@
+import { getByteFormatter } from "../../utils.js";
+const byteFormatter = getByteFormatter(unit => {
+    return {
+        unitDisplay: unit === "byte" ? "long" : "short",
+        maximumFractionDigits: 1,
+    };
+});
+
 const clearBrowsingData = document.querySelector("#clear-browsing-data");
 const clearBrowsingDataCachedFiles = document.querySelector("#clear-browsing-data-cached-files");
 const clearBrowsingDataCachedFilesSize = document.querySelector("#clear-browsing-data-cached-files-size");
@@ -10,37 +18,6 @@ const clearBrowsingDataTimeRange = document.querySelector("#clear-browsing-data-
 const clearBrowsingDataTotalSize = document.querySelector("#clear-browsing-data-total-size");
 const globalPrivacyControlToggle = document.querySelector("#global-privacy-control-toggle");
 
-const BYTE_UNITS = ["byte", "kilobyte", "megabyte", "gigabyte", "terabyte"];
-
-const BYTE_FORMATTERS = {
-    byte: undefined,
-    kilobyte: undefined,
-    megabyte: undefined,
-    gigabyte: undefined,
-    terabyte: undefined,
-};
-
-function formatBytes(bytes) {
-    let index = 0;
-    while (bytes >= 1024 && index < BYTE_UNITS.length - 1) {
-        bytes /= 1024;
-        ++index;
-    }
-
-    const unit = BYTE_UNITS[index];
-
-    if (!BYTE_FORMATTERS[unit]) {
-        BYTE_FORMATTERS[unit] = new Intl.NumberFormat([], {
-            style: "unit",
-            unit: unit,
-            unitDisplay: unit === "byte" ? "long" : "short",
-            maximumFractionDigits: 1,
-        });
-    }
-
-    return BYTE_FORMATTERS[unit].format(bytes);
-}
-
 function loadSettings(settings) {
     globalPrivacyControlToggle.checked = settings.globalPrivacyControl;
 }
@@ -74,10 +51,10 @@ function estimateBrowsingDataSizes() {
 function updateBrowsingDataSizes(sizes) {
     const totalSize = sizes.totalCacheSize + sizes.totalSiteDataSize;
 
-    clearBrowsingDataTotalSize.innerText = `Your browsing data is currently using ${formatBytes(totalSize)} of disk space`;
+    clearBrowsingDataTotalSize.innerText = `Your browsing data is currently using ${byteFormatter.formatBytes(totalSize)} of disk space`;
 
-    clearBrowsingDataCachedFilesSize.innerText = ` (remove ${formatBytes(sizes.cacheSizeSinceRequestedTime)})`;
-    clearBrowsingDataSiteDataSize.innerText = ` (remove ${formatBytes(sizes.siteDataSizeSinceRequestedTime)})`;
+    clearBrowsingDataCachedFilesSize.innerText = ` (remove ${byteFormatter.formatBytes(sizes.cacheSizeSinceRequestedTime)})`;
+    clearBrowsingDataSiteDataSize.innerText = ` (remove ${byteFormatter.formatBytes(sizes.siteDataSizeSinceRequestedTime)})`;
 }
 
 clearBrowsingData.addEventListener("click", () => {
diff --git a/Base/res/ladybird/utils.js b/Base/res/ladybird/utils.js
new file mode 100644
index 00000000000..6e0893d7102
--- /dev/null
+++ b/Base/res/ladybird/utils.js
@@ -0,0 +1,32 @@
+export function getByteFormatter(optionsFunction) {
+    const BYTE_UNITS = ["byte", "kilobyte", "megabyte", "gigabyte", "terabyte"];
+    const BYTE_FORMATTERS = {
+        byte: undefined,
+        kilobyte: undefined,
+        megabyte: undefined,
+        gigabyte: undefined,
+        terabyte: undefined,
+        petabyte: undefined,
+    };
+    return {
+        formatBytes: bytes => {
+            let index = 0;
+            while (bytes >= 1024 && index < BYTE_UNITS.length - 1) {
+                bytes /= 1024;
+                ++index;
+            }
+
+            const unit = BYTE_UNITS[index];
+
+            if (!BYTE_FORMATTERS[unit]) {
+                let options = { style: "unit", unit: unit };
+                if (optionsFunction) {
+                    options = { ...options, ...optionsFunction(unit) };
+                }
+                BYTE_FORMATTERS[unit] = new Intl.NumberFormat([], options);
+            }
+
+            return BYTE_FORMATTERS[unit].format(bytes);
+        },
+    };
+}
diff --git a/UI/cmake/ResourceFiles.cmake b/UI/cmake/ResourceFiles.cmake
index 2a942b99b6e..f5fa79eb336 100644
--- a/UI/cmake/ResourceFiles.cmake
+++ b/UI/cmake/ResourceFiles.cmake
@@ -63,6 +63,7 @@ list(TRANSFORM BROWSER_ICONS PREPEND "${LADYBIRD_SOURCE_DIR}/Base/res/icons/brow
 
 set(INTERNAL_RESOURCES
     ladybird.css
+    utils.js
 )
 list(TRANSFORM INTERNAL_RESOURCES PREPEND "${LADYBIRD_SOURCE_DIR}/Base/res/ladybird/")