Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-10-19 15:43:20 +00:00
Code Issues Projects Releases Packages Wiki Activity

LibWasm: Avoid allocations for the label stack as much as possible

Browse source 
Namely, find an upper bound at validation time so we can allocate the
space when entering the frame.

Also drop labels at once instead of popping them off one at a time now
that we're using a Vector.
This commit is contained in:
Ali Mohammad Pur 2025-08-20 13:54:14 +02:00 • committed by Ali Mohammad Pur
parent 191499696b
commit f7bdc596b4
Notes: github-actions[bot] 2025-08-26 13:22:01 +00:00
5 changed files with 19 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Libraries/LibWasm/AbstractMachine/BytecodeInterpreter.cpp
View file

@ -267,8 +267,7 @@ void BytecodeInterpreter::interpret_impl(Configuration& configuration, Expressio
RUN_NEXT_INSTRUCTION(CouldHaveChangedIP::Yes);
}
case Instructions::return_.value(): {
while (configuration.label_stack().size() - 1 != configuration.frame().label_index())
configuration.label_stack().take_last();
configuration.label_stack().shrink(configuration.frame().label_index() + 1, true);
configuration.ip() = max_ip_value;
RUN_NEXT_INSTRUCTION(CouldHaveChangedIP::Yes);
}
@ -2233,8 +2232,8 @@ void BytecodeInterpreter::interpret_impl(Configuration& configuration, Expressio
void BytecodeInterpreter::branch_to_label(Configuration& configuration, LabelIndex index)
{
dbgln_if(WASM_TRACE_DEBUG, "Branch to label with index {}...", index.value());
for (size_t i = 0; i < index.value(); ++i)
configuration.label_stack().take_last();
auto& label_stack = configuration.label_stack();
label_stack.shrink(label_stack.size() - index.value(), true);
auto label = configuration.label_stack().last();
dbgln_if(WASM_TRACE_DEBUG, "...which is actually IP {}, and has {} result(s)", label.continuation().value(), label.arity());