Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-10-31 13:20:59 +00:00
Code Issues Projects Releases Packages Wiki Activity
37237 commits 1 branch 0 tags 522 MiB
Commit graph

148 commits

Author SHA1 Message Date
Linus Groh
e109b967a1 LibJS: Make options object const in more Temporal AOs 2022-04-08 00:43:17 +01:00
Linus Groh
2844a2c448 LibJS: Handle undefined options in MergeLargestUnitOption 
This is an editorial change in the Temporal spec.

See: 5e161a2
 2022-04-08 00:43:17 +01:00
Linus Groh
151eb8606d LibJS: Consistently call observable Temporal AOs with undefined options 
This is a normative change in the Temporal spec.

See: 6fa5b9d
 2022-04-07 12:58:39 +01:00
Linus Groh
e4fe60b972 LibJS: Update incorrect spec comment in ToRelativeTemporalObject 
This is a normative change in the Temporal spec.

See: 4cb192d
 2022-03-29 22:56:03 +01:00
Linus Groh
2ad69d789b LibJS: Remove the ConstrainToRange AO 
This is an editorial change in the Temporal spec.

See: 537b3e6
 2022-03-16 21:49:38 +00:00
Linus Groh
1521c5f55c LibJS: Remove argument type assertion from ParseTemporalDurationString 
This is an editorial change in the Temporal spec.

See: 8615b41
 2022-03-16 21:49:38 +00:00
Linus Groh
54af3a5396 LibJS: Adjust grammar for DateExtendedYear to exclude -000000 
This is an editorial change in the Temporal spec.

See: fb3e656

We lose the custom error message, but it's not the end of the world.
 2022-03-10 23:20:39 +01:00
Linus Groh
68af8649fb LibJS: Follow rules for consuming completion records 
This is an editorial change in the Temporal spec.

See: 1c19b96
 2022-03-10 23:20:39 +01:00
Linus Groh
2bae040bc9 LibJS: Remove Sign abstract operation 
This is an editorial change in the Temporal spec.

See: bbc1ebc
 2022-03-10 23:20:39 +01:00
Linus Groh
34371b9b61 LibJS: Fix numeric type confusion in ToTemporalRoundingIncrement 
This is an editorial change in the Temporal spec.

See: 6e59366
 2022-03-10 23:20:39 +01:00
Linus Groh
a496868ee5 LibJS: Create Duration Records with their own abstract operations 
This is an editorial change in the Temporal spec.

See:
- 387c405
- b203e26
- 387c405
 2022-03-10 23:20:39 +01:00
Linus Groh
bdb13a74b0 LibJS: Describe various kinds of "Duration Records" 
This is an editorial change in the Temporal spec.

See: 983902e

We already had these defined as structs, but now they're properly
defined in the spec (opposed to the previous anonymous records), and we
don't have to make up our own names anymore :^)

Note that while we're usually not including 'record' in the name, in
this case the 'Duration Record' has a name clash with the Duration
object. Additionally, later editorial changes introduce CreateFooRecord
AOs, so let's just go with FooRecord structs here.
 2022-03-10 23:20:39 +01:00
Linus Groh
bc183dbbcb LibJS: Replace uses of MarkedValueList with MarkedVector<Value> 
This is effectively a drop-in replacement.
 2022-02-09 12:25:27 +00:00
Linus Groh
c48f695b90 LibJS: Remove '-000000' check from ParseTemporalYearMonthString 
This is an editorial change in the Temporal spec.

See: 3be4b5d
 2022-02-04 20:00:34 +00:00
Linus Groh
28ac5a1333 LibJS: Update fallibility of ParseISODateTime in spec comments 
This is an editorial change in the Temporal spec.

See: bc79069
 2022-02-04 20:00:34 +00:00
Linus Groh
40ba12aa7d LibJS: Consider calls of parse_iso_date_time() fallible 
See: https://github.com/tc39/proposal-temporal/pull/2027
 2022-02-02 18:55:00 +00:00
Linus Groh
19a2b32065 LibJS: Reject '-000000' as extended year 
This is a normative change in the Temporal spec.

See: e60ef9e
 2022-02-02 14:46:52 +00:00
Idan Horowitz
ace36681ff LibJS+LibIMAP: Use the new Optional<U>(Optional<T>) constructor 
These look much nicer than these repeated ternaries :^)
 2022-01-23 18:53:42 +02:00
Linus Groh
0e3def1d0b LibJS: Don't parse/re-format offset in parse_temporal_time_zone_string() 
This is an editorial change in the Temporal spec.

See: 6abe146
 2022-01-23 00:22:10 +00:00
Linus Groh
6d744eb4a7 LibJS: Use consistent name for offset strings 
This is an editorial change in the Temporal spec.

See: 17f8cdb
 2022-01-23 00:22:10 +00:00
Linus Groh
b9093dd0ab LibJS: Don't validate time zone name when parsing Instant string 
This is normative change in the Temporal spec.

See: 2a81fbc
 2022-01-13 10:08:34 +01:00
Linus Groh
392f5bfebd LibJS: Fix fraction substring range in parse_temporal_time_zone_string() 
Two issues:

- The intended range was 9 characters starting from index 1. Since the
  second argument to String::substring() is the length, 10 is
  potentially reading further than the string's length (when only
  providing one fraction digit), causing an assertion failure crash.
- The spec's intention to skip the decimal separator by starting at
  index 1 is incorrect, no decimal separator is present in the result of
  parsing TimeZoneUTCOffsetFractionalPart. I filed a spec fix for this,
  see: https://github.com/tc39/proposal-temporal/pull/1999
 2022-01-12 21:24:12 +01:00
Linus Groh
027e4bd439 LibJS: Fix calculation overflow in parse_temporal_time_zone_string() 
As all variables and numeric literals in the expression have an integral
data type, it would evaluate to an int and could easily overflow as
we're multiplying seconds with 10^9.

Introduce a floating point literal into the expression to make it result
in a double.
 2022-01-12 21:24:12 +01:00
Linus Groh
323e1e17cf LibJS: Fix sign data type in parse_temporal_time_zone_string() 
A sign that's either the value 1 or -1 should obviously not have an
unsigned data type :^)

This would cause it to become 255 for the negative offset case, which
would then completely screw up the offset_nanoseconds calculation as it
serves as a multiplier.
 2022-01-12 21:24:12 +01:00
Linus Groh
09a11fa6ea LibJS: Implement proper Iterator records 
Instead of using plain objects as Iterator records, causes confusion
about the object itself actually being its [[Iterator]] slot, and
requires non-standard type conversion shenanigans fpr the [[NextValue]]
and [[Done]] internal slots,  implement a proper Iterator record struct
and use it throughout.

Also annotate the remaining Iterator AOs with spec comments while we're
here.
 2022-01-09 22:02:43 +01:00
Linus Groh
3301b0b33d LibJS: Remove duplicate assignment step from parse_iso_date_time() 
This is an editorial change in the Temporal spec.

See: eb68de2
 2022-01-08 00:31:28 +01:00
Linus Groh
d42336312c LibJS: Include time zone name in TemporalInvalidTimeZoneName error 2022-01-06 21:49:50 +01:00
Linus Groh
29e96eceeb LibJS: Convert PropertyKey::from_value() to ThrowCompletionOr 
Lots of MUST() - perhaps we'll eventually come up with a better API for
the common case where it can't fail.
 2022-01-04 23:37:26 +00:00
Linus Groh
3ab1c52e2b LibJS: Require 'T' prefix for ambiguous time-only strings 
This is a normative change in the Temporal spec.

See: 514ede3
 2021-12-24 00:07:52 +01:00
Linus Groh
9271005357 LibJS: Fix typo in spec comment 2021-12-19 09:35:02 +00:00
Linus Groh
f7fe7f8c77 LibJS: Capture TimeFraction parse result instead of Fraction 
Not much of a difference as TimeFraction just parses Fraction, but let's
do it correctly. Small mistake I did in 4b7f716.

Thanks to YouTube user gla3dr for noticing this :^)
 2021-12-19 09:29:46 +00:00
Linus Groh
4b7f716f21 LibJS: Fix ambiguity in FractionalPart grammar 
This is a normative change in the Temporal spec.

See: 0f11bd6
 2021-12-18 22:32:39 +00:00
Linus Groh
006bea5d31 LibJS: Remove outdated comment in prepare_partial_temporal_fields() 
This is a normative change in the Temporal spec.

See: bf066ea
 2021-12-18 22:32:39 +00:00
Linus Groh
7270bbb255 LibJS: Remove outdated comment from parse_temporal_duration_string() 
This is a normative change in the Temporal spec.

See:

- e7182d3
- 6dae066
 2021-12-18 22:32:39 +00:00
Luke Wilde
4f3c283f24 LibJS: Move calendar validation out of parse_temporal_calendar_string 
This is an editorial change in the Temporal spec.

See: 7207a1c
 2021-12-08 19:11:50 +00:00
Luke Wilde
80dcddacea LibJS: Simplify return in parse_temporal_date_time_string 
This is an editorial change in the Temporal spec.

See: 1f7e486
 2021-12-08 19:11:50 +00:00
Luke Wilde
6244969ae2 LibJS: Remove duplicated spec step in parse_iso_date_time 
This is an editorial change in the Temporal spec.

See: 516bf24
 2021-12-08 19:11:50 +00:00
Timothy Flynn
1039159a6c LibJS: Change LargerOfTwoTemporalUnits AO to return a StringView 2021-11-30 00:01:07 +00:00
Linus Groh
f7ba81ac52 LibJS: Implement parsing of TemporalDurationString 2021-11-28 10:32:28 +00:00
Linus Groh
1e41a8668d LibJS: Add sign(Crypto::SignedBigInteger const&) overload 2021-11-24 17:53:00 +00:00
Linus Groh
78724fdd33 LibJS: Don't accept UTC designators in strings for plain Temporal types 
This is a normative change in the Temporal spec.

See: cd2dc7d
 2021-11-24 08:56:03 +00:00
Linus Groh
836ce8ee5d LibJS: Fix parse ErrorType used in parse_temporal_date_string() 
TemporalInvalidDateString, not TemporalInvalidDateTimeString.
 2021-11-24 08:38:50 +00:00
Linus Groh
55dbd19a16 LibJS: Update to_largest_temporal_unit() to allow undefined fallback 
This is required for Temporal.Duration.prototype.round(). Subsequently,
this now returns ThrowCompletionOr<Optional<String>>, which brings the
signature in line with that of to_smallest_temporal_unit().
Much nicer! :^)
 2021-11-23 21:03:05 +00:00
Linus Groh
783222f87a LibJS: Implement parsing of TemporalInstantString 2021-11-20 23:10:09 +00:00
Linus Groh
79a18b058f LibJS: Implement parsing of TemporalCalendarString 2021-11-20 23:10:09 +00:00
Linus Groh
1583c7257c LibJS: Implement parsing of TemporalRelativeToString 2021-11-20 23:10:09 +00:00
Linus Groh
98b876ad3f LibJS: Implement parsing of TemporalZonedDateTimeString 2021-11-20 23:10:09 +00:00
Linus Groh
3b1de431cc LibJS: Implement parsing of TemporalYearMonthString 2021-11-20 23:10:09 +00:00
Linus Groh
3ddab2f4fe LibJS: Implement parsing of TemporalMonthDayString 2021-11-20 23:10:09 +00:00
Linus Groh
453c78215c LibJS: Implement parsing of TemporalTimeString 2021-11-20 23:10:09 +00:00