ladybird/Libraries/LibCore/EventReceiver.h
Zaggy1024 8c96f7b3aa LibCore: Stop atomically ref-counting EventReceiver
Inheriting from AtomicRefCounted and Weakable is asking for misuse of
WeakPtr to result in TOCTOU-caused UAFs.

In order to ensure we're not misusing EventReceiver across threads, I
ran test-web and some sites with a temporary hack to verify that ref()s
and unref()s are always called from the same thread on the class.
2026-03-02 17:06:39 -06:00

82 lines
2.3 KiB
C++

/*
* Copyright (c) 2018-2025, Andreas Kling <andreas@ladybird.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#pragma once
#include <AK/AtomicRefCounted.h>
#include <AK/Forward.h>
#include <AK/Noncopyable.h>
#include <AK/StringView.h>
#include <AK/Weakable.h>
#include <LibCore/Export.h>
#include <LibCore/Forward.h>
namespace Core {
#define C_OBJECT(klass) \
public: \
virtual StringView class_name() const override \
{ \
return #klass##sv; \
} \
template<typename Klass = klass, class... Args> \
static NonnullRefPtr<klass> construct(Args&&... args) \
{ \
return adopt_ref(*new Klass(::forward<Args>(args)...)); \
}
#define C_OBJECT_ABSTRACT(klass) \
public: \
virtual StringView class_name() const override \
{ \
return #klass##sv; \
}
class CORE_API EventReceiver
: public RefCounted<EventReceiver>
, public Weakable<EventReceiver> {
// NOTE: No C_OBJECT macro for Core::EventReceiver itself.
AK_MAKE_NONCOPYABLE(EventReceiver);
AK_MAKE_NONMOVABLE(EventReceiver);
public:
virtual ~EventReceiver();
virtual StringView class_name() const = 0;
template<typename T>
bool fast_is() const = delete;
void start_timer(int ms);
void stop_timer();
bool has_timer() const { return m_timer_id; }
void deferred_invoke(Function<void()>);
void dispatch_event(Core::Event&);
protected:
EventReceiver();
virtual void event(Core::Event&);
virtual void timer_event(TimerEvent&);
private:
intptr_t m_timer_id { 0 };
};
}
template<>
struct AK::Formatter<Core::EventReceiver> : AK::Formatter<FormatString> {
ErrorOr<void> format(FormatBuilder& builder, Core::EventReceiver const& value)
{
return AK::Formatter<FormatString>::format(builder, "{}({})"sv, value.class_name(), &value);
}
};