mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2026-04-18 09:50:27 +00:00
HTMLParser::the_end() had three spin_until calls that blocked the event loop: step 5 (deferred scripts), step 7 (ASAP scripts), and step 8 (load event delay). This replaces them with an HTMLParserEndState state machine that progresses asynchronously via callbacks. The state machine has three phases matching the three spin_until calls: - WaitingForDeferredScripts: loops executing ready deferred scripts - WaitingForASAPScripts: waits for ASAP script lists to empty - WaitingForLoadEventDelay: waits for nothing to delay the load event Notification triggers re-evaluate the state machine when conditions change: HTMLScriptElement::mark_as_ready, stylesheet unblocking in StyleElementBase/HTMLLinkElement, did_stop_being_active_document, and DocumentLoadEventDelayer decrements. NavigableContainer state changes (session history readiness, content navigable cleared, lazy load flag) also trigger re-evaluation of the load event delay check. Key design decisions and why: 1. Microtask checkpoint in schedule_progress_check(): The old spin_until called perform_a_microtask_checkpoint() before checking conditions. This is critical because HTMLImageElement::update_the_image_data step 8 queues a microtask that creates the DocumentLoadEventDelayer. Without the checkpoint, check_progress() would see zero delayers and complete before images start delaying the load event. 2. deferred_invoke in schedule_progress_check(): I tried Core::Timer (0ms), queue_global_task, and synchronous calls. Timers caused non-deterministic ordering with the HTML event loop's task processing timer, leading to image layout tests failing (wrong subtest pass/fail patterns). Synchronous calls fired too early during image load processing before dimensions were set, causing 0-height images in layout tests. queue_global_task had task ordering issues with the session history traversal queue. deferred_invoke runs after the current callback returns but within the same event loop pump, giving the right balance. 3. Navigation load event guard (m_navigation_load_event_guard): During cross-document navigation, finalize_a_cross_document_navigation step 2 calls set_delaying_load_events(false) before the session history traversal activates the new document. This creates a transient state where the parent's load event delay check sees the about:blank (which has ready_for_post_load_tasks=true) as the active document and completes prematurely.
175 lines
8.2 KiB
C++
175 lines
8.2 KiB
C++
/*
|
|
* Copyright (c) 2023, Preston Taylor <PrestonLeeTaylor@proton.me>
|
|
* Copyright (c) 2025, Lorenz Ackermann <me@lorenzackermann.xyz>
|
|
* Copyright (c) 2026, Sam Atkins <sam@ladybird.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <LibWeb/CSS/Parser/Parser.h>
|
|
#include <LibWeb/CSS/StyleComputer.h>
|
|
#include <LibWeb/CSS/StyleSheetList.h>
|
|
#include <LibWeb/ContentSecurityPolicy/BlockingAlgorithms.h>
|
|
#include <LibWeb/DOM/Document.h>
|
|
#include <LibWeb/DOM/Event.h>
|
|
#include <LibWeb/DOM/ShadowRoot.h>
|
|
#include <LibWeb/DOM/StyleElementBase.h>
|
|
#include <LibWeb/HTML/EventNames.h>
|
|
#include <LibWeb/Infra/Strings.h>
|
|
|
|
namespace Web::DOM {
|
|
|
|
// The user agent must run the "update a style block" algorithm whenever one of the following conditions occur:
|
|
// FIXME: The element is popped off the stack of open elements of an HTML parser or XML parser.
|
|
//
|
|
// NOTE: This is basically done by children_changed() today:
|
|
// The element's children changed steps run.
|
|
//
|
|
// NOTE: This is basically done by inserted() and removed_from() today:
|
|
// The element is not on the stack of open elements of an HTML parser or XML parser, and it becomes connected or disconnected.
|
|
//
|
|
// https://html.spec.whatwg.org/multipage/semantics.html#update-a-style-block
|
|
void StyleElementBase::update_a_style_block()
|
|
{
|
|
auto& style_element = as_element();
|
|
|
|
// OPTIMIZATION: Skip parsing CSS if we're in the middle of parsing a HTML fragment.
|
|
// The style block will be parsed upon insertion into a proper document.
|
|
if (style_element.document().is_temporary_document_for_fragment_parsing())
|
|
return;
|
|
|
|
// 1. Let element be the style element.
|
|
// 2. If element has an associated CSS style sheet, remove the CSS style sheet in question.
|
|
|
|
if (m_associated_css_style_sheet) {
|
|
m_style_sheet_list->remove_a_css_style_sheet(*m_associated_css_style_sheet);
|
|
m_style_sheet_list = nullptr;
|
|
|
|
// FIXME: This should probably be handled by StyleSheet::set_owner_node().
|
|
m_associated_css_style_sheet = nullptr;
|
|
}
|
|
|
|
// 3. If element is not connected, then return.
|
|
if (!style_element.is_connected())
|
|
return;
|
|
|
|
// 4. If element's type attribute is present and its value is neither the empty string nor an ASCII case-insensitive match for "text/css", then return.
|
|
auto type_attribute = style_element.attribute(HTML::AttributeNames::type);
|
|
if (type_attribute.has_value() && !type_attribute->is_empty() && !type_attribute->bytes_as_string_view().equals_ignoring_ascii_case("text/css"sv))
|
|
return;
|
|
|
|
// 5. If the Should element's inline behavior be blocked by Content Security Policy? algorithm returns "Blocked" when executed upon the style element, "style", and the style element's child text content, then return. [CSP]
|
|
if (ContentSecurityPolicy::should_elements_inline_type_behavior_be_blocked_by_content_security_policy(style_element.realm(), style_element, ContentSecurityPolicy::Directives::Directive::InlineType::Style, style_element.child_text_content().to_utf8_but_should_be_ported_to_utf16()) == ContentSecurityPolicy::Directives::Directive::Result::Blocked)
|
|
return;
|
|
|
|
// 6. Create a CSS style sheet with the following properties:
|
|
// type
|
|
// text/css
|
|
// owner node
|
|
// element
|
|
// media
|
|
// The media attribute of element.
|
|
// title
|
|
// The title attribute of element, if element is in a document tree, or the empty string otherwise.
|
|
// alternate flag
|
|
// Unset.
|
|
// origin-clean flag
|
|
// Set.
|
|
// location
|
|
// parent CSS style sheet
|
|
// owner CSS rule
|
|
// null
|
|
// disabled flag
|
|
// Left at its default value.
|
|
// CSS rules
|
|
// Left uninitialized.
|
|
m_style_sheet_list = style_element.document_or_shadow_root_style_sheets();
|
|
m_associated_css_style_sheet = m_style_sheet_list->create_a_css_style_sheet(
|
|
style_element.text_content().value_or({}).to_utf8_but_should_be_ported_to_utf16(),
|
|
"text/css"_string,
|
|
&style_element,
|
|
style_element.attribute(HTML::AttributeNames::media).value_or({}),
|
|
style_element.in_a_document_tree()
|
|
? style_element.attribute(HTML::AttributeNames::title).value_or({})
|
|
: String {},
|
|
CSS::StyleSheetList::Alternate::No,
|
|
CSS::StyleSheetList::OriginClean::Yes,
|
|
{},
|
|
nullptr,
|
|
nullptr);
|
|
|
|
// 7. If element contributes a script-blocking style sheet, append element to its node document's script-blocking style sheet set.
|
|
if (style_element.contributes_a_script_blocking_style_sheet()) {
|
|
m_document_load_event_delayer.emplace(style_element.document());
|
|
style_element.document().script_blocking_style_sheet_set().set(style_element);
|
|
}
|
|
|
|
// FIXME: 8. If element's media attribute's value matches the environment and element is potentially render-blocking, then block rendering on element.
|
|
|
|
// AD-HOC: Check if we have already loaded the sheet's resources.
|
|
auto loading_state = m_associated_css_style_sheet->loading_state();
|
|
if (loading_state == CSS::CSSStyleSheet::LoadingState::Loaded || loading_state == CSS::CSSStyleSheet::LoadingState::Error) {
|
|
finished_loading_critical_subresources(loading_state == CSS::CSSStyleSheet::LoadingState::Error ? AnyFailed::Yes : AnyFailed::No);
|
|
}
|
|
}
|
|
|
|
// https://html.spec.whatwg.org/multipage/semantics.html#the-style-element:critical-subresources
|
|
void StyleElementBase::finished_loading_critical_subresources(AnyFailed any_failed)
|
|
{
|
|
// 1. Let element be the style element associated with the style sheet in question.
|
|
auto& element = as_element();
|
|
|
|
// 2. Let success be true.
|
|
auto success = true;
|
|
|
|
// 3. If the attempts to obtain any of the style sheet's critical subresources failed for any reason
|
|
// (e.g., DNS error, HTTP 404 response, a connection being prematurely closed, unsupported Content-Type),
|
|
// set success to false.
|
|
// Note that content-specific errors, e.g., CSS parse errors or PNG decoding errors, do not affect success.
|
|
if (any_failed == AnyFailed::Yes)
|
|
success = false;
|
|
|
|
// 4. Queue an element task on the networking task source given element and the following steps:
|
|
element.queue_an_element_task(HTML::Task::Source::UserInteraction, [&element, success] {
|
|
// 1. If success is true, fire an event named load at element.
|
|
// AD-HOC: these should call fire an event this is not implemented anywhere so we dispatch it ourselves
|
|
if (success)
|
|
element.dispatch_event(DOM::Event::create(element.realm(), HTML::EventNames::load));
|
|
// 2. Otherwise, fire an event named error at element.
|
|
else
|
|
element.dispatch_event(DOM::Event::create(element.realm(), HTML::EventNames::error));
|
|
// 3. If element contributes a script-blocking style sheet:
|
|
if (element.contributes_a_script_blocking_style_sheet()) {
|
|
// 1. Assert: element's node document's script-blocking style sheet set contains element.
|
|
VERIFY(element.document().script_blocking_style_sheet_set().contains(element));
|
|
// 2. Remove element from its node document's script-blocking style sheet set.
|
|
element.document().script_blocking_style_sheet_set().remove(element);
|
|
element.document().schedule_html_parser_end_check();
|
|
}
|
|
// 4. Unblock rendering on element.
|
|
element.unblock_rendering();
|
|
});
|
|
m_document_load_event_delayer.clear();
|
|
}
|
|
|
|
// https://www.w3.org/TR/cssom/#dom-linkstyle-sheet
|
|
CSS::CSSStyleSheet* StyleElementBase::sheet()
|
|
{
|
|
// The sheet attribute must return the associated CSS style sheet for the node or null if there is no associated CSS style sheet.
|
|
return m_associated_css_style_sheet;
|
|
}
|
|
|
|
// https://www.w3.org/TR/cssom/#dom-linkstyle-sheet
|
|
CSS::CSSStyleSheet const* StyleElementBase::sheet() const
|
|
{
|
|
// The sheet attribute must return the associated CSS style sheet for the node or null if there is no associated CSS style sheet.
|
|
return m_associated_css_style_sheet;
|
|
}
|
|
|
|
void StyleElementBase::visit_style_element_edges(JS::Cell::Visitor& visitor)
|
|
{
|
|
visitor.visit(m_associated_css_style_sheet);
|
|
visitor.visit(m_style_sheet_list);
|
|
}
|
|
|
|
}
|