mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-10-19 15:43:20 +00:00
b6b56910e8
If the Ladybird process crashes or just ends normally, the IPC transport connection with WebContent may be shutdown after a send sync event (for example: WebContentClient DidRequestCookie) was sent from WebContent, but before the Ladybird process provided the matching sync event response (for example: WebContentClient DidRequestCookieResponse). This can lead to a runaway WebContent process if other IPC events (for example: WebContentServer DidPaint, or SetSystemVisibilityState, or MouseEvent, or CloseServer, etc...) are also queued when the IPC connection is shutdown. At the core of the issue is that the loop waiting for the matching send sync response will prioritize waiting for the response and remain spinning even if the IPC connection is reporting that it was shutdown, but only if there happens to be other unrelated events received before the IPC shutdown is detected. These unrelated events will not be processed because the loop is stuck waiting for the response that due to the Ladybird process having stopped, will never be sent. Because the shutdown of the IPC connection is not handled when other events happen to be also present, new events may be posted for transfer by the WebContent process if the page is very active. If many new events are posted this could lead to a slow or very quick memory leak in the WebContent process due to the queue growing large, sometimes all the way to total system memory exhaustion. If no events or only a few new events are sent, then the leak may be hard to detect. This PR fixes the faulty IPC shutdown handling by not getting stuck if any messages are present in the receive queue. Before returning to the caller any remaining messages will be immediately processed. |
||
|---|---|---|
| .. | ||
| AutoCloseFileDescriptor.h | ||
| CMakeLists.txt | ||
| Concepts.h | ||
| Connection.cpp | ||
| Connection.h | ||
| ConnectionFromClient.h | ||
| ConnectionToServer.h | ||
| Decoder.cpp | ||
| Decoder.h | ||
| Encoder.cpp | ||
| Encoder.h | ||
| File.cpp | ||
| File.h | ||
| FileWindows.cpp | ||
| Forward.h | ||
| HandleType.h | ||
| Message.cpp | ||
| Message.h | ||
| MessageWindows.cpp | ||
| MultiServer.h | ||
| SingleServer.h | ||
| Stub.h | ||
| Transport.h | ||
| TransportSocket.cpp | ||
| TransportSocket.h | ||
| TransportSocketWindows.cpp | ||
| TransportSocketWindows.h | ||