mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-10-19 15:43:20 +00:00
21ff66c6cb
From the SVG spec The value of the ‘viewBox’ attribute is a list of four numbers <min-x>, <min-y>, <width> and <height>, separated by whitespace and/or a comma... Currently try_parse_view_box will fail to parse the attribute if the values are separated by commas. This change replaces try_parse_view_box with a more correct implementation. It will reside in the AttributeParser.cpp. This new implementation correctly handles comma-separated viewBox values, and is also more robust against invalid inputs. Additionally, it adds a new test case to ensure viewBox values with various syntax are parsed correctly and invalid values are rejected.
45 lines
1.8 KiB
C++
45 lines
1.8 KiB
C++
/*
|
|
* Copyright (c) 2025, Tim Ledbetter <tim.ledbetter@ladybird.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <LibJS/Runtime/Realm.h>
|
|
#include <LibWeb/DOM/Element.h>
|
|
#include <LibWeb/SVG/AttributeNames.h>
|
|
#include <LibWeb/SVG/SVGAnimatedRect.h>
|
|
#include <LibWeb/SVG/SVGFitToViewBox.h>
|
|
|
|
namespace Web::SVG {
|
|
|
|
void SVGFitToViewBox::initialize(JS::Realm& realm)
|
|
{
|
|
m_view_box_for_bindings = realm.create<SVGAnimatedRect>(realm);
|
|
}
|
|
|
|
void SVGFitToViewBox::visit_edges(JS::Cell::Visitor& visitor)
|
|
{
|
|
visitor.visit(m_view_box_for_bindings);
|
|
}
|
|
|
|
void SVGFitToViewBox::attribute_changed(DOM::Element& element, FlyString const& name, Optional<String> const& value)
|
|
{
|
|
if (name.equals_ignoring_ascii_case(SVG::AttributeNames::viewBox)) {
|
|
if (!value.has_value()) {
|
|
m_view_box_for_bindings->set_nulled(true);
|
|
} else {
|
|
m_view_box = AttributeParser::parse_viewbox(value.value_or(String {}));
|
|
m_view_box_for_bindings->set_nulled(!m_view_box.has_value());
|
|
if (m_view_box.has_value()) {
|
|
m_view_box_for_bindings->set_base_val(Gfx::DoubleRect { m_view_box->min_x, m_view_box->min_y, m_view_box->width, m_view_box->height });
|
|
m_view_box_for_bindings->set_anim_val(Gfx::DoubleRect { m_view_box->min_x, m_view_box->min_y, m_view_box->width, m_view_box->height });
|
|
}
|
|
}
|
|
element.set_needs_layout_tree_update(true, DOM::SetNeedsLayoutTreeUpdateReason::SVGViewBoxChange);
|
|
} else if (name.equals_ignoring_ascii_case(SVG::AttributeNames::preserveAspectRatio)) {
|
|
m_preserve_aspect_ratio = AttributeParser::parse_preserve_aspect_ratio(value.value_or(String {}));
|
|
element.set_needs_layout_tree_update(true, DOM::SetNeedsLayoutTreeUpdateReason::SVGViewBoxChange);
|
|
}
|
|
}
|
|
|
|
}
|