mirror of
				https://github.com/LadybirdBrowser/ladybird.git
				synced 2025-10-31 13:20:59 +00:00 
			
		
		
		
	 890b4d7980
			
		
	
	
		890b4d7980
		
	
	
	
	
		
			
			This replaces the FlyStrings for ARIA roles that were constructed in a [[gnu::constructor]] with a single enum. I came across this as the DOM inspector was crashing due to a null FlyString for an ARIA role. After fixing that, I was confused as to why these roles were not an enum. Looking at the spec there's a fixed list of roles and switching from references to static strings to an enum was pretty much an exercise in find and replace :). No functional changes (outside of fixing the mentioned crash).
		
			
				
	
	
		
			77 lines
		
	
	
	
		
			2.5 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			77 lines
		
	
	
	
		
			2.5 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
| /*
 | |
|  * Copyright (c) 2020, the SerenityOS developers.
 | |
|  * Copyright (c) 2021-2022, Andreas Kling <kling@serenityos.org>
 | |
|  * Copyright (c) 2022, Luke Wilde <lukew@serenityos.org>
 | |
|  *
 | |
|  * SPDX-License-Identifier: BSD-2-Clause
 | |
|  */
 | |
| 
 | |
| #pragma once
 | |
| 
 | |
| #include <LibWeb/HTML/FormAssociatedElement.h>
 | |
| #include <LibWeb/HTML/HTMLElement.h>
 | |
| #include <LibWeb/HTML/HTMLOptionsCollection.h>
 | |
| 
 | |
| namespace Web::HTML {
 | |
| 
 | |
| class HTMLSelectElement final
 | |
|     : public HTMLElement
 | |
|     , public FormAssociatedElement {
 | |
|     WEB_PLATFORM_OBJECT(HTMLSelectElement, HTMLElement);
 | |
|     FORM_ASSOCIATED_ELEMENT(HTMLElement, HTMLSelectElement)
 | |
| 
 | |
| public:
 | |
|     virtual ~HTMLSelectElement() override;
 | |
| 
 | |
|     JS::GCPtr<HTMLOptionsCollection> const& options();
 | |
| 
 | |
|     size_t length();
 | |
|     DOM::Element* item(size_t index);
 | |
|     DOM::Element* named_item(DeprecatedFlyString const& name);
 | |
|     WebIDL::ExceptionOr<void> add(HTMLOptionOrOptGroupElement element, Optional<HTMLElementOrElementIndex> before = {});
 | |
| 
 | |
|     int selected_index() const;
 | |
|     void set_selected_index(int);
 | |
| 
 | |
|     Vector<JS::Handle<HTMLOptionElement>> list_of_options() const;
 | |
| 
 | |
|     // ^EventTarget
 | |
|     // https://html.spec.whatwg.org/multipage/interaction.html#the-tabindex-attribute:the-select-element
 | |
|     virtual bool is_focusable() const override { return true; }
 | |
| 
 | |
|     // ^FormAssociatedElement
 | |
|     // https://html.spec.whatwg.org/multipage/forms.html#category-listed
 | |
|     virtual bool is_listed() const override { return true; }
 | |
| 
 | |
|     // https://html.spec.whatwg.org/multipage/forms.html#category-submit
 | |
|     virtual bool is_submittable() const override { return true; }
 | |
| 
 | |
|     // https://html.spec.whatwg.org/multipage/forms.html#category-reset
 | |
|     virtual bool is_resettable() const override { return true; }
 | |
| 
 | |
|     // https://html.spec.whatwg.org/multipage/forms.html#category-autocapitalize
 | |
|     virtual bool is_auto_capitalize_inheriting() const override { return true; }
 | |
| 
 | |
|     // ^HTMLElement
 | |
|     // https://html.spec.whatwg.org/multipage/forms.html#category-label
 | |
|     virtual bool is_labelable() const override { return true; }
 | |
| 
 | |
|     virtual void reset_algorithm() override;
 | |
| 
 | |
|     DeprecatedString const& type() const;
 | |
| 
 | |
|     virtual Optional<DOM::ARIARoles::Role> default_role() const override;
 | |
| 
 | |
| private:
 | |
|     HTMLSelectElement(DOM::Document&, DOM::QualifiedName);
 | |
| 
 | |
|     virtual void initialize(JS::Realm&) override;
 | |
|     virtual void visit_edges(Cell::Visitor&) override;
 | |
| 
 | |
|     // ^DOM::Element
 | |
|     virtual i32 default_tab_index_value() const override;
 | |
| 
 | |
|     JS::GCPtr<HTMLOptionsCollection> m_options;
 | |
| };
 | |
| 
 | |
| }
 |