mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2026-04-19 02:10:26 +00:00
2645695fdd
Previously, the active document's lifecycle was bound to SessionHistoryEntry via DocumentState. The ownership chain was: Navigable → SessionHistoryEntry → DocumentState → Document This made it impossible to move SessionHistoryEntry to the UI process (which cannot own DOM::Document). This commit decouples the two by giving Navigable a direct m_active_document field that serves as the authoritative source for active_document(). - Navigable owns m_active_document directly; active_document() reads from it instead of going through the active session history entry. - DocumentState no longer holds a Document pointer. Instead, it stores a document_id for "same document?" checks. Same-document navigations share a DocumentState and thus the same document_id, while cross-document navigations create a new DocumentState with a new ID. - A pending_document parameter is threaded through finalize_a_cross_document_navigation → apply_the_push_or_replace → apply_the_history_step so the newly created document reaches activation without being stored on DocumentState. - For traversal, the population output delivers the document. A resolved_document is computed per continuation from either the pending document, the population output, or the current active document (for same-document traversals).
30 lines
786 B
C++
30 lines
786 B
C++
/*
|
|
* Copyright (c) 2022, Andreas Kling <andreas@ladybird.org>
|
|
* Copyright (c) 2023, Aliaksandr Kalenik <kalenik.aliaksandr@gmail.com>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <LibWeb/HTML/DocumentState.h>
|
|
#include <LibWeb/HTML/SessionHistoryEntry.h>
|
|
|
|
namespace Web::HTML {
|
|
|
|
GC_DEFINE_ALLOCATOR(DocumentState);
|
|
|
|
DocumentState::DocumentState() = default;
|
|
|
|
DocumentState::~DocumentState() = default;
|
|
|
|
void DocumentState::visit_edges(Cell::Visitor& visitor)
|
|
{
|
|
Base::visit_edges(visitor);
|
|
m_history_policy_container.visit(
|
|
[&](GC::Ref<PolicyContainer> const& policy_container) { visitor.visit(policy_container); },
|
|
[](auto const&) {});
|
|
for (auto& nested_history : m_nested_histories) {
|
|
visitor.visit(nested_history.entries);
|
|
}
|
|
}
|
|
|
|
}
|