ladybird/Libraries/LibWeb/SVG/SVGGradientElement.cpp
Jelle Raaijmakers 4dbae64dce LibWeb: Unify objectBoundingBox and userSpaceOnUse coord transformations
There's a fairly complicated interaction between an SVG gradient's paint
transformation and the gradient coordinate transformation required to
correctly draw gradient fills. This was especially noticeable when
scaling down an SVG, resulting in broken gradient coordinates and
graphical glitches.

This changes the objectBoundingBox units to immediately map to the
bounding box's coordinate system, so we can unify the gradient paint
transformation logic and make it a lot simpler. We only need to undo the
bounding box offset and apply the paint transformation to fix a lot of
gradient fill bugs.
2025-10-27 16:42:27 -07:00

171 lines
6.4 KiB
C++

/*
* Copyright (c) 2023, MacDue <macdue@dueutil.tech>
* Copyright (c) 2025, Jelle Raaijmakers <jelle@ladybird.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#include <LibWeb/Bindings/Intrinsics.h>
#include <LibWeb/Bindings/SVGGradientElementPrototype.h>
#include <LibWeb/CSS/ComputedProperties.h>
#include <LibWeb/DOM/Document.h>
#include <LibWeb/Painting/PaintStyle.h>
#include <LibWeb/SVG/AttributeNames.h>
#include <LibWeb/SVG/SVGGradientElement.h>
#include <LibWeb/SVG/SVGGraphicsElement.h>
namespace Web::SVG {
SVGGradientElement::SVGGradientElement(DOM::Document& document, DOM::QualifiedName qualified_name)
: SVGElement(document, move(qualified_name))
{
}
void SVGGradientElement::attribute_changed(FlyString const& name, Optional<String> const& old_value, Optional<String> const& value, Optional<FlyString> const& namespace_)
{
Base::attribute_changed(name, old_value, value, namespace_);
if (name == AttributeNames::gradientUnits) {
m_gradient_units = AttributeParser::parse_units(value.value_or(String {}));
} else if (name == AttributeNames::spreadMethod) {
m_spread_method = AttributeParser::parse_spread_method(value.value_or(String {}));
} else if (name == AttributeNames::gradientTransform) {
if (auto transform_list = AttributeParser::parse_transform(value.value_or(String {})); transform_list.has_value()) {
m_gradient_transform = transform_from_transform_list(*transform_list);
} else {
m_gradient_transform = {};
}
}
}
GradientUnits SVGGradientElement::gradient_units() const
{
HashTable<SVGGradientElement const*> seen_gradients;
return gradient_units_impl(seen_gradients);
}
GradientUnits SVGGradientElement::gradient_units_impl(HashTable<SVGGradientElement const*>& seen_gradients) const
{
if (m_gradient_units.has_value())
return *m_gradient_units;
if (auto gradient = linked_gradient(seen_gradients))
return gradient->gradient_units_impl(seen_gradients);
return GradientUnits::ObjectBoundingBox;
}
SpreadMethod SVGGradientElement::spread_method() const
{
HashTable<SVGGradientElement const*> seen_gradients;
return spread_method_impl(seen_gradients);
}
SpreadMethod SVGGradientElement::spread_method_impl(HashTable<SVGGradientElement const*>& seen_gradients) const
{
if (m_spread_method.has_value())
return *m_spread_method;
if (auto gradient = linked_gradient(seen_gradients))
return gradient->spread_method_impl(seen_gradients);
return SpreadMethod::Pad;
}
Gfx::InterpolationColorSpace SVGGradientElement::color_space() const
{
switch (computed_properties()->color_interpolation()) {
case CSS::ColorInterpolation::Linearrgb:
return Gfx::InterpolationColorSpace::LinearRGB;
case CSS::ColorInterpolation::Auto:
case CSS::ColorInterpolation::Srgb:
return Gfx::InterpolationColorSpace::SRGB;
}
VERIFY_NOT_REACHED();
}
Optional<Gfx::AffineTransform> SVGGradientElement::gradient_transform() const
{
HashTable<SVGGradientElement const*> seen_gradients;
return gradient_transform_impl(seen_gradients);
}
Optional<Gfx::AffineTransform> SVGGradientElement::gradient_transform_impl(HashTable<SVGGradientElement const*>& seen_gradients) const
{
if (m_gradient_transform.has_value())
return m_gradient_transform;
if (auto gradient = linked_gradient(seen_gradients))
return gradient->gradient_transform_impl(seen_gradients);
return {};
}
// The gradient transform, appropriately scaled and combined with the paint transform.
Gfx::AffineTransform SVGGradientElement::gradient_paint_transform(SVGPaintContext const& paint_context) const
{
auto gradient_paint_transform = Gfx::AffineTransform {};
gradient_paint_transform.set_translation(-paint_context.paint_transform.map(paint_context.path_bounding_box).location())
.multiply(paint_context.paint_transform);
if (auto transform = gradient_transform(); transform.has_value())
gradient_paint_transform.multiply(transform.value());
return gradient_paint_transform;
}
void SVGGradientElement::add_color_stops(Painting::SVGGradientPaintStyle& paint_style) const
{
auto largest_offset = 0.0f;
for_each_color_stop([&](auto& stop) {
// https://svgwg.org/svg2-draft/pservers.html#StopNotes
// Gradient offset values less than 0 (or less than 0%) are rounded up to 0%.
// Gradient offset values greater than 1 (or greater than 100%) are rounded down to 100%.
float stop_offset = AK::clamp(stop.stop_offset(), 0.0f, 1.0f);
// Each gradient offset value is required to be equal to or greater than the previous gradient
// stop's offset value. If a given gradient stop's offset value is not equal to or greater than all
// previous offset values, then the offset value is adjusted to be equal to the largest of all previous
// offset values.
stop_offset = AK::max(stop_offset, largest_offset);
largest_offset = stop_offset;
paint_style.add_color_stop(stop_offset, stop.stop_color().with_opacity(stop.stop_opacity()));
});
}
GC::Ptr<SVGGradientElement const> SVGGradientElement::linked_gradient(HashTable<SVGGradientElement const*>& seen_gradients) const
{
// FIXME: This entire function is an ad-hoc hack!
// It can only resolve #<ids> in the same document.
auto link = has_attribute(AttributeNames::href) ? get_attribute(AttributeNames::href) : get_attribute("xlink:href"_fly_string);
if (auto href = link; href.has_value() && !link->is_empty()) {
auto url = document().encoding_parse_url(*href);
if (!url.has_value())
return {};
auto id = url->fragment();
if (!id.has_value() || id->is_empty())
return {};
auto element = document().get_element_by_id(id.value());
if (!element)
return {};
if (element == this)
return {};
if (!is<SVGGradientElement>(*element))
return {};
if (seen_gradients.set(&as<SVGGradientElement>(*element)) != AK::HashSetResult::InsertedNewEntry)
return {};
return &as<SVGGradientElement>(*element);
}
return {};
}
void SVGGradientElement::initialize(JS::Realm& realm)
{
WEB_SET_PROTOTYPE_FOR_INTERFACE(SVGGradientElement);
Base::initialize(realm);
}
void SVGGradientElement::visit_edges(Cell::Visitor& visitor)
{
Base::visit_edges(visitor);
SVGURIReferenceMixin::visit_edges(visitor);
}
}