mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2026-04-19 02:10:26 +00:00
cc711a6060
Storage objects are created lazily when window.localStorage or window.sessionStorage is first accessed. Previously, broadcast() iterated over already-created Storage objects, so windows that had never accessed these properties would not receive storage events. Fix this by iterating over all active windows and initializing Storage objects as part of the broadcast loop so all eligible windows receive the event regardless of whether they had previously accessed their storage property.
63 lines
2 KiB
C++
63 lines
2 KiB
C++
/*
|
|
* Copyright (c) 2022, Andreas Kling <andreas@ladybird.org>
|
|
* Copyright (c) 2023, Luke Wilde <lukew@serenityos.org>
|
|
* Copyright (c) 2024-2025, Shannon Booth <shannon@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <LibWeb/Bindings/PlatformObject.h>
|
|
#include <LibWeb/Export.h>
|
|
#include <LibWeb/StorageAPI/StorageBottle.h>
|
|
#include <LibWeb/WebIDL/ExceptionOr.h>
|
|
|
|
namespace Web::HTML {
|
|
|
|
// https://html.spec.whatwg.org/multipage/webstorage.html#storage-2
|
|
class WEB_API Storage : public Bindings::PlatformObject {
|
|
WEB_PLATFORM_OBJECT(Storage, Bindings::PlatformObject);
|
|
GC_DECLARE_ALLOCATOR(Storage);
|
|
|
|
public:
|
|
// https://html.spec.whatwg.org/multipage/webstorage.html#concept-storage-type
|
|
enum class Type {
|
|
Local,
|
|
Session,
|
|
};
|
|
|
|
[[nodiscard]] static GC::Ref<Storage> create(JS::Realm&, Type, GC::Ref<StorageAPI::StorageBottle>);
|
|
|
|
~Storage();
|
|
|
|
size_t length() const;
|
|
Optional<String> key(size_t index);
|
|
Optional<String> get_item(String const& key) const;
|
|
WebIDL::ExceptionOr<void> set_item(String const& key, String const& value);
|
|
void remove_item(String const& key);
|
|
void clear();
|
|
Type type() const { return m_type; }
|
|
|
|
void dump() const;
|
|
|
|
private:
|
|
Storage(JS::Realm&, Type, GC::Ref<StorageAPI::StorageBottle>);
|
|
|
|
virtual void initialize(JS::Realm&) override;
|
|
virtual void visit_edges(GC::Cell::Visitor&) override;
|
|
|
|
// ^PlatformObject
|
|
virtual JS::Value named_item_value(FlyString const&) const override;
|
|
virtual WebIDL::ExceptionOr<DidDeletionFail> delete_value(String const&) override;
|
|
virtual Vector<FlyString> supported_property_names() const override;
|
|
virtual WebIDL::ExceptionOr<void> set_value_of_named_property(String const& key, JS::Value value) override;
|
|
|
|
void reorder();
|
|
void broadcast(Optional<String> const& key, Optional<String> const& old_value, Optional<String> const& new_value);
|
|
|
|
Type m_type {};
|
|
GC::Ref<StorageAPI::StorageBottle> m_storage_bottle;
|
|
};
|
|
|
|
}
|