mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2026-04-19 02:10:26 +00:00
d89f3fc5e6
Add a clang plugin check that flags GC::Cell subclasses (and their base classes within the Cell hierarchy) that have destructors with non-trivial bodies. Such logic should use Cell::finalize() instead. Add GC_ALLOW_CELL_DESTRUCTOR annotation macro for opting out in exceptional cases (currently only JS::Object). This prevents us from accidentally adding code in destructors that runs after something we're pointing to may have been destroyed. (This could become a problem when the garbage collector sweeps objects in an unfortunate order.) This new check uncovered a handful of bugs which are then also fixed in this commit. :^)
50 lines
1.1 KiB
C++
50 lines
1.1 KiB
C++
/*
|
|
* Copyright (c) 2020, Andreas Kling <andreas@ladybird.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <AK/Forward.h>
|
|
#include <AK/Function.h>
|
|
#include <AK/WeakPtr.h>
|
|
#include <LibCore/Forward.h>
|
|
#include <LibGC/Function.h>
|
|
#include <LibGC/Ptr.h>
|
|
#include <LibJS/Heap/Cell.h>
|
|
#include <LibWeb/Forward.h>
|
|
|
|
namespace Web::HTML {
|
|
|
|
class Timer final : public JS::Cell {
|
|
GC_CELL(Timer, JS::Cell);
|
|
GC_DECLARE_ALLOCATOR(Timer);
|
|
|
|
public:
|
|
enum class Repeating {
|
|
No,
|
|
Yes,
|
|
};
|
|
|
|
static constexpr bool OVERRIDES_FINALIZE = true;
|
|
|
|
static GC::Ref<Timer> create(JS::Object&, i32 milliseconds, Function<void()> callback, i32 id, Repeating);
|
|
|
|
void start();
|
|
void stop();
|
|
|
|
void set_callback(Function<void()>);
|
|
|
|
private:
|
|
Timer(JS::Object& window, i32 milliseconds, Function<void()> callback, i32 id, Repeating);
|
|
|
|
virtual void visit_edges(Cell::Visitor&) override;
|
|
virtual void finalize() override;
|
|
|
|
RefPtr<Core::Timer> m_timer;
|
|
GC::Ref<JS::Object> m_window_or_worker_global_scope;
|
|
i32 m_id { 0 };
|
|
};
|
|
|
|
}
|