mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2026-04-19 18:30:27 +00:00
00fe4a2946
SVGPolygonElement::get_path() produces a path based on the points attribute. During layout, this path is copied into paintables. If the points attribute changes after layout, the path stored in the paintable becomes stale. Fix by calling set_needs_layout_update() when it changes so the path is recomputed.
61 lines
1.8 KiB
C++
61 lines
1.8 KiB
C++
/*
|
|
* Copyright (c) 2022, Sam Atkins <atkinssj@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <LibGfx/Path.h>
|
|
#include <LibWeb/Bindings/Intrinsics.h>
|
|
#include <LibWeb/Bindings/SVGPolygonElementPrototype.h>
|
|
#include <LibWeb/Layout/Node.h>
|
|
#include <LibWeb/SVG/AttributeNames.h>
|
|
#include <LibWeb/SVG/AttributeParser.h>
|
|
#include <LibWeb/SVG/SVGPolygonElement.h>
|
|
|
|
namespace Web::SVG {
|
|
|
|
GC_DEFINE_ALLOCATOR(SVGPolygonElement);
|
|
|
|
SVGPolygonElement::SVGPolygonElement(DOM::Document& document, DOM::QualifiedName qualified_name)
|
|
: SVGGeometryElement(document, qualified_name)
|
|
{
|
|
}
|
|
|
|
void SVGPolygonElement::initialize(JS::Realm& realm)
|
|
{
|
|
WEB_SET_PROTOTYPE_FOR_INTERFACE(SVGPolygonElement);
|
|
Base::initialize(realm);
|
|
}
|
|
|
|
void SVGPolygonElement::attribute_changed(FlyString const& name, Optional<String> const& old_value, Optional<String> const& value, Optional<FlyString> const& namespace_)
|
|
{
|
|
Base::attribute_changed(name, old_value, value, namespace_);
|
|
|
|
if (name == SVG::AttributeNames::points) {
|
|
m_points = AttributeParser::parse_points(value.value_or(String {}));
|
|
if (layout_node())
|
|
layout_node()->set_needs_layout_update(DOM::SetNeedsLayoutReason::StyleChange);
|
|
}
|
|
}
|
|
|
|
Gfx::Path SVGPolygonElement::get_path(CSSPixelSize)
|
|
{
|
|
Gfx::Path path;
|
|
|
|
if (m_points.is_empty())
|
|
return path;
|
|
|
|
// 1. perform an absolute moveto operation to the first coordinate pair in the list of points
|
|
path.move_to(m_points.first());
|
|
|
|
// 2. for each subsequent coordinate pair, perform an absolute lineto operation to that coordinate pair.
|
|
for (size_t point_index = 1; point_index < m_points.size(); ++point_index)
|
|
path.line_to(m_points[point_index]);
|
|
|
|
// 3. perform a closepath command
|
|
path.close();
|
|
|
|
return path;
|
|
}
|
|
|
|
}
|