mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2026-04-19 18:30:27 +00:00
419afa544c
When multiple views share a WebContent process (e.g. parent and child views created via window.open()), we need to notify ALL of them when the process crashes, not just one. Previously, each view would overwrite the single crash callback on WebContentClient, so only the last view to initialize would be notified. This adds WebContentClient::notify_all_views_of_crash() which iterates over all registered views and notifies each one. Child views also now propagate crashes to their parent, and can be disconnected between tests to prevent stale crashes from affecting subsequent tests.
53 lines
1.8 KiB
C++
53 lines
1.8 KiB
C++
/*
|
|
* Copyright (c) 2024-2025, Tim Flynn <trflynn89@ladybird.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <LibCore/Forward.h>
|
|
#include <LibGfx/Forward.h>
|
|
#include <LibWeb/Page/Page.h>
|
|
#include <LibWeb/PixelUnits.h>
|
|
#include <LibWebView/Forward.h>
|
|
#include <LibWebView/ViewImplementation.h>
|
|
|
|
namespace WebView {
|
|
|
|
class WEBVIEW_API HeadlessWebView : public WebView::ViewImplementation {
|
|
public:
|
|
static NonnullOwnPtr<HeadlessWebView> create(Core::AnonymousBuffer theme, Web::DevicePixelSize window_size);
|
|
static NonnullOwnPtr<HeadlessWebView> create_child(HeadlessWebView&, u64 page_index);
|
|
|
|
void disconnect_child_crash_handlers()
|
|
{
|
|
// Disconnect crash handlers so child crashes don't propagate to parent.
|
|
// We don't destroy the children because there may be pending deferred_invokes
|
|
// that would cause use-after-free.
|
|
for (auto& child : m_child_web_views) {
|
|
child->on_web_content_crashed = nullptr;
|
|
child->disconnect_child_crash_handlers();
|
|
}
|
|
}
|
|
|
|
protected:
|
|
HeadlessWebView(Core::AnonymousBuffer theme, Web::DevicePixelSize viewport_size);
|
|
|
|
void initialize_client(CreateNewClient) override;
|
|
void update_zoom() override;
|
|
|
|
virtual Web::DevicePixelSize viewport_size() const override { return m_viewport_size; }
|
|
virtual Gfx::IntPoint to_content_position(Gfx::IntPoint widget_position) const override { return widget_position; }
|
|
virtual Gfx::IntPoint to_widget_position(Gfx::IntPoint content_position) const override { return content_position; }
|
|
|
|
Core::AnonymousBuffer m_theme;
|
|
Web::DevicePixelSize m_viewport_size;
|
|
|
|
Web::Page::PendingDialog m_pending_dialog { Web::Page::PendingDialog::None };
|
|
Optional<String> m_pending_prompt_text;
|
|
|
|
Vector<NonnullOwnPtr<HeadlessWebView>> m_child_web_views;
|
|
};
|
|
|
|
}
|