ladybird/Libraries/LibWeb/CSS/StyleValues/CursorStyleValue.cpp
Aliaksandr Kalenik 5bfc4a3c41 LibWeb: Cache display list commands per paintable
Cache the display list commands produced by each PaintableBox's paint()
on a per-phase basis. On subsequent display list rebuilds, if a
paintable's cache is still valid, replay the recorded commands directly
— skipping paint() and all the property resolution it entails.

Besides saving time on property resolution, this also enables Skia to
reuse path tessellation results across frames — e.g. border paths are
preserved in the cache and don't need to be re-tessellated on every
repaint.
2026-03-04 19:35:45 +01:00

139 lines
5.9 KiB
C++
Raw Blame History

This file contains ambiguous Unicode characters

This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

/*
* Copyright (c) 2025, Sam Atkins <sam@ladybird.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#include "CursorStyleValue.h"
#include <LibGfx/Bitmap.h>
#include <LibGfx/Painter.h>
#include <LibGfx/PaintingSurface.h>
#include <LibWeb/CSS/Sizing.h>
#include <LibWeb/CSS/StyleValues/AbstractImageStyleValue.h>
#include <LibWeb/CSS/StyleValues/CalculatedStyleValue.h>
#include <LibWeb/CSS/StyleValues/NumberStyleValue.h>
#include <LibWeb/DOM/Document.h>
#include <LibWeb/Layout/Node.h>
#include <LibWeb/Page/Page.h>
#include <LibWeb/Painting/DisplayListPlayerSkia.h>
#include <LibWeb/Painting/DisplayListRecorder.h>
namespace Web::CSS {
void CursorStyleValue::serialize(StringBuilder& builder, SerializationMode mode) const
{
m_properties.image->serialize(builder, mode);
if (m_properties.x) {
VERIFY(m_properties.y);
builder.append(' ');
m_properties.x->serialize(builder, mode);
builder.append(' ');
m_properties.y->serialize(builder, mode);
}
}
ValueComparingNonnullRefPtr<StyleValue const> CursorStyleValue::absolutized(ComputationContext const& computation_context) const
{
RefPtr<StyleValue const> absolutized_x;
RefPtr<StyleValue const> absolutized_y;
if (m_properties.x)
absolutized_x = m_properties.x->absolutized(computation_context);
if (m_properties.y)
absolutized_y = m_properties.y->absolutized(computation_context);
return CursorStyleValue::create(m_properties.image->absolutized(computation_context)->as_abstract_image(), absolutized_x, absolutized_y);
}
Optional<Gfx::ImageCursor> CursorStyleValue::make_image_cursor(Layout::NodeWithStyle const& layout_node) const
{
auto const& image = *m_properties.image;
if (!image.is_paintable()) {
const_cast<AbstractImageStyleValue&>(image).load_any_resources(const_cast<DOM::Document&>(layout_node.document()));
return {};
}
auto const& document = layout_node.document();
CacheKey cache_key {
.length_resolution_context = Length::ResolutionContext::for_layout_node(layout_node),
.current_color = layout_node.computed_values().color(),
};
// Create a bitmap if needed.
// The cursor size for a given image never changes. It's based either on the image itself, or our default size,
// neither of which is affected by what layout node it's for.
if (!m_cached_bitmap.has_value()) {
// Determine the size of the cursor.
// "The default object size for cursor images is a UA-defined size that should be based on the size of a
// typical cursor on the UAs operating system.
// The concrete object size is determined using the default sizing algorithm. If an operating system is
// incapable of rendering a cursor above a given size, cursors larger than that size must be shrunk to
// within the OS-supported size bounds, while maintaining the cursor images natural aspect ratio, if any."
// https://drafts.csswg.org/css-ui-3/#cursor
// 32x32 is selected arbitrarily.
// FIXME: Ask the OS for the default size?
CSSPixelSize const default_cursor_size { 32, 32 };
auto cursor_css_size = run_default_sizing_algorithm({}, {}, { image.natural_width(), image.natural_height(), image.natural_aspect_ratio() }, default_cursor_size);
// FIXME: How do we determine what cursor sizes the OS allows?
// We don't multiply by the pixel ratio, because we want to use the image's actual pixel size.
DevicePixelSize cursor_device_size { cursor_css_size.to_type<double>().to_rounded<int>() };
auto maybe_bitmap = Gfx::Bitmap::create_shareable(Gfx::BitmapFormat::BGRA8888, Gfx::AlphaType::Premultiplied, cursor_device_size.to_type<int>());
if (maybe_bitmap.is_error()) {
dbgln("Failed to create cursor bitmap: {}", maybe_bitmap.error());
return {};
}
auto bitmap = maybe_bitmap.release_value();
m_cached_bitmap = bitmap->to_shareable_bitmap();
}
// Repaint the bitmap if necessary
if (m_cache_key != cache_key) {
m_cache_key = move(cache_key);
// Clear whatever was in the bitmap before.
auto& bitmap = *m_cached_bitmap->bitmap();
auto painter = Gfx::Painter::create(bitmap);
painter->clear_rect(bitmap.rect().to_type<float>(), Color::Transparent);
// Paint the cursor into a bitmap.
auto display_list = Painting::DisplayList::create();
Painting::DisplayListRecorder display_list_recorder(display_list);
DisplayListRecordingContext paint_context { display_list_recorder, document.page().palette(), document.page().client().device_pixels_per_css_pixel(), document.page().chrome_metrics() };
image.resolve_for_size(layout_node, CSSPixelSize { bitmap.size() });
image.paint(paint_context, DevicePixelRect { bitmap.rect() }, ImageRendering::Auto);
switch (document.page().client().display_list_player_type()) {
case DisplayListPlayerType::SkiaGPUIfAvailable:
case DisplayListPlayerType::SkiaCPU: {
auto painting_surface = Gfx::PaintingSurface::wrap_bitmap(bitmap);
Painting::DisplayListPlayerSkia display_list_player;
display_list_player.execute(*display_list, {}, painting_surface);
break;
}
}
}
// "If the values are unspecified, then the natural hotspot defined inside the image resource itself is used.
// If both the values are unspecific and the referenced cursor has no defined hotspot, the effect is as if a
// value of "0 0" were specified."
// FIXME: Make use of embedded hotspots.
Gfx::IntPoint hotspot = { 0, 0 };
if (m_properties.x && m_properties.y) {
VERIFY(document.window());
hotspot = { number_from_style_value(*m_properties.x, {}), number_from_style_value(*m_properties.y, {}) };
}
return Gfx::ImageCursor {
.bitmap = *m_cached_bitmap,
.hotspot = hotspot
};
}
}