mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2026-04-18 18:00:31 +00:00
b4185f0ecd
Use dedicated Packed branches in GetByValue and PutByValue so in-bounds indexed accesses can skip hole checks and slot reloads. Keep Holey writes on the guarded arm, and keep append writes on the C++ slow path so PutByValue still respects non-extensible indexed objects and arrays with a non-writable length. Add a bytecode regression that exercises both append failure cases through the real js binary path.
78 lines
2.7 KiB
C++
78 lines
2.7 KiB
C++
/*
|
|
* Copyright (c) 2024, Aliaksandr Kalenik <kalenik.aliaksandr@gmail.com>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <LibWeb/Bindings/ExceptionOrUtils.h>
|
|
#include <LibWeb/WebIDL/ObservableArray.h>
|
|
|
|
namespace Web::WebIDL {
|
|
|
|
GC_DEFINE_ALLOCATOR(ObservableArray);
|
|
|
|
GC::Ref<ObservableArray> ObservableArray::create(JS::Realm& realm)
|
|
{
|
|
auto prototype = realm.intrinsics().array_prototype();
|
|
return realm.create<ObservableArray>(realm, prototype);
|
|
}
|
|
|
|
ObservableArray::ObservableArray(JS::Realm& realm, Object& prototype)
|
|
: JS::Array(realm, prototype)
|
|
{
|
|
set_may_interfere_with_indexed_property_access();
|
|
}
|
|
|
|
void ObservableArray::visit_edges(JS::Cell::Visitor& visitor)
|
|
{
|
|
Base::visit_edges(visitor);
|
|
visitor.visit(m_on_set_an_indexed_value);
|
|
visitor.visit(m_on_delete_an_indexed_value);
|
|
}
|
|
|
|
void ObservableArray::set_on_set_an_indexed_value_callback(SetAnIndexedValueCallbackFunction&& callback)
|
|
{
|
|
m_on_set_an_indexed_value = GC::create_function(heap(), move(callback));
|
|
}
|
|
|
|
void ObservableArray::set_on_delete_an_indexed_value_callback(DeleteAnIndexedValueCallbackFunction&& callback)
|
|
{
|
|
m_on_delete_an_indexed_value = GC::create_function(heap(), move(callback));
|
|
}
|
|
|
|
JS::ThrowCompletionOr<bool> ObservableArray::internal_set(JS::PropertyKey const& property_key, JS::Value value, JS::Value receiver, JS::CacheableSetPropertyMetadata* metadata, PropertyLookupPhase phase)
|
|
{
|
|
if (property_key.is_number() && m_on_set_an_indexed_value)
|
|
TRY(Bindings::throw_dom_exception_if_needed(vm(), [&] { return m_on_set_an_indexed_value->function()(value); }));
|
|
return TRY(Base::internal_set(property_key, value, receiver, metadata, phase));
|
|
}
|
|
|
|
JS::ThrowCompletionOr<bool> ObservableArray::internal_delete(JS::PropertyKey const& property_key)
|
|
{
|
|
if (property_key.is_number() && m_on_delete_an_indexed_value) {
|
|
auto maybe_value_and_attributes = indexed_get(property_key.as_number());
|
|
JS::Value deleted_value;
|
|
if (maybe_value_and_attributes.has_value())
|
|
deleted_value = maybe_value_and_attributes->value;
|
|
TRY(Bindings::throw_dom_exception_if_needed(vm(), [&] { return m_on_delete_an_indexed_value->function()(deleted_value); }));
|
|
}
|
|
return JS::Array::internal_delete(property_key);
|
|
}
|
|
|
|
JS::ThrowCompletionOr<void> ObservableArray::append(JS::Value value)
|
|
{
|
|
if (m_on_set_an_indexed_value)
|
|
TRY(Bindings::throw_dom_exception_if_needed(vm(), [&] { return m_on_set_an_indexed_value->function()(value); }));
|
|
indexed_append(value);
|
|
return {};
|
|
}
|
|
|
|
void ObservableArray::clear()
|
|
{
|
|
while (indexed_array_like_size() != 0) {
|
|
auto deleted_value = indexed_take_first().value;
|
|
MUST(m_on_delete_an_indexed_value->function()(deleted_value));
|
|
}
|
|
}
|
|
|
|
}
|