mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2026-04-18 18:00:31 +00:00
614713ed08
Replace the OwnPtr<IndexedPropertyStorage> indirection with inline indexed element storage directly on Object. This eliminates virtual dispatch and reduces indirection for indexed property access. The new system uses three storage kinds tracked by IndexedStorageKind: - Packed: Dense array, no holes. Elements stored in a malloced Value* array with capacity header (same layout as named properties). - Holey: Dense array with possible holes marked by empty sentinel. Same physical layout as Packed. - Dictionary: Sparse storage using GenericIndexedPropertyStorage, type-punned into the m_indexed_elements pointer. Transitions: None->Packed->Holey->Dictionary (mostly monotonic). Dictionary mode triggers on non-default attributes or sparse arrays. Object keeps the same 48-byte size since m_indexed_elements (8 bytes) replaces IndexedProperties (8 bytes), and the storage kind + array size fit in existing padding alongside m_flags. The asm interpreter benefits from one fewer indirection: it now reads the element pointer and array size directly from Object fields instead of chasing through OwnPtr -> IndexedPropertyStorage -> Vector. Removes: IndexedProperties, SimpleIndexedPropertyStorage, IndexedPropertyStorage, IndexedPropertyIterator. Keeps: GenericIndexedPropertyStorage (for Dictionary mode).
77 lines
2.7 KiB
C++
77 lines
2.7 KiB
C++
/*
|
|
* Copyright (c) 2024, Aliaksandr Kalenik <kalenik.aliaksandr@gmail.com>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <LibWeb/Bindings/ExceptionOrUtils.h>
|
|
#include <LibWeb/WebIDL/ObservableArray.h>
|
|
|
|
namespace Web::WebIDL {
|
|
|
|
GC_DEFINE_ALLOCATOR(ObservableArray);
|
|
|
|
GC::Ref<ObservableArray> ObservableArray::create(JS::Realm& realm)
|
|
{
|
|
auto prototype = realm.intrinsics().array_prototype();
|
|
return realm.create<ObservableArray>(realm, prototype);
|
|
}
|
|
|
|
ObservableArray::ObservableArray(JS::Realm& realm, Object& prototype)
|
|
: JS::Array(realm, prototype)
|
|
{
|
|
}
|
|
|
|
void ObservableArray::visit_edges(JS::Cell::Visitor& visitor)
|
|
{
|
|
Base::visit_edges(visitor);
|
|
visitor.visit(m_on_set_an_indexed_value);
|
|
visitor.visit(m_on_delete_an_indexed_value);
|
|
}
|
|
|
|
void ObservableArray::set_on_set_an_indexed_value_callback(SetAnIndexedValueCallbackFunction&& callback)
|
|
{
|
|
m_on_set_an_indexed_value = GC::create_function(heap(), move(callback));
|
|
}
|
|
|
|
void ObservableArray::set_on_delete_an_indexed_value_callback(DeleteAnIndexedValueCallbackFunction&& callback)
|
|
{
|
|
m_on_delete_an_indexed_value = GC::create_function(heap(), move(callback));
|
|
}
|
|
|
|
JS::ThrowCompletionOr<bool> ObservableArray::internal_set(JS::PropertyKey const& property_key, JS::Value value, JS::Value receiver, JS::CacheableSetPropertyMetadata* metadata, PropertyLookupPhase phase)
|
|
{
|
|
if (property_key.is_number() && m_on_set_an_indexed_value)
|
|
TRY(Bindings::throw_dom_exception_if_needed(vm(), [&] { return m_on_set_an_indexed_value->function()(value); }));
|
|
return TRY(Base::internal_set(property_key, value, receiver, metadata, phase));
|
|
}
|
|
|
|
JS::ThrowCompletionOr<bool> ObservableArray::internal_delete(JS::PropertyKey const& property_key)
|
|
{
|
|
if (property_key.is_number() && m_on_delete_an_indexed_value) {
|
|
auto maybe_value_and_attributes = indexed_get(property_key.as_number());
|
|
JS::Value deleted_value;
|
|
if (maybe_value_and_attributes.has_value())
|
|
deleted_value = maybe_value_and_attributes->value;
|
|
TRY(Bindings::throw_dom_exception_if_needed(vm(), [&] { return m_on_delete_an_indexed_value->function()(deleted_value); }));
|
|
}
|
|
return JS::Array::internal_delete(property_key);
|
|
}
|
|
|
|
JS::ThrowCompletionOr<void> ObservableArray::append(JS::Value value)
|
|
{
|
|
if (m_on_set_an_indexed_value)
|
|
TRY(Bindings::throw_dom_exception_if_needed(vm(), [&] { return m_on_set_an_indexed_value->function()(value); }));
|
|
indexed_append(value);
|
|
return {};
|
|
}
|
|
|
|
void ObservableArray::clear()
|
|
{
|
|
while (indexed_array_like_size() != 0) {
|
|
auto deleted_value = indexed_take_first().value;
|
|
MUST(m_on_delete_an_indexed_value->function()(deleted_value));
|
|
}
|
|
}
|
|
|
|
}
|