mirror of
				https://github.com/LadybirdBrowser/ladybird.git
				synced 2025-10-31 13:20:59 +00:00 
			
		
		
		
	 890b4d7980
			
		
	
	
		890b4d7980
		
	
	
	
	
		
			
			This replaces the FlyStrings for ARIA roles that were constructed in a [[gnu::constructor]] with a single enum. I came across this as the DOM inspector was crashing due to a null FlyString for an ARIA role. After fixing that, I was confused as to why these roles were not an enum. Looking at the spec there's a fixed list of roles and switching from references to static strings to an enum was pretty much an exercise in find and replace :). No functional changes (outside of fixing the mentioned crash).
		
			
				
	
	
		
			64 lines
		
	
	
	
		
			2.4 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			64 lines
		
	
	
	
		
			2.4 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
| /*
 | |
|  * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
 | |
|  *
 | |
|  * SPDX-License-Identifier: BSD-2-Clause
 | |
|  */
 | |
| 
 | |
| #pragma once
 | |
| 
 | |
| #include <LibWeb/HTML/HTMLElement.h>
 | |
| #include <LibWeb/HTML/HTMLHyperlinkElementUtils.h>
 | |
| 
 | |
| namespace Web::HTML {
 | |
| 
 | |
| class HTMLAnchorElement final
 | |
|     : public HTMLElement
 | |
|     , public HTMLHyperlinkElementUtils {
 | |
|     WEB_PLATFORM_OBJECT(HTMLAnchorElement, HTMLElement);
 | |
| 
 | |
| public:
 | |
|     virtual ~HTMLAnchorElement() override;
 | |
| 
 | |
|     DeprecatedString rel() const { return attribute(HTML::AttributeNames::rel); }
 | |
|     DeprecatedString target() const { return attribute(HTML::AttributeNames::target); }
 | |
|     DeprecatedString download() const { return attribute(HTML::AttributeNames::download); }
 | |
| 
 | |
|     // ^EventTarget
 | |
|     // https://html.spec.whatwg.org/multipage/interaction.html#the-tabindex-attribute:the-a-element
 | |
|     virtual bool is_focusable() const override { return has_attribute(HTML::AttributeNames::href); }
 | |
| 
 | |
|     virtual bool is_html_anchor_element() const override { return true; }
 | |
| 
 | |
| private:
 | |
|     HTMLAnchorElement(DOM::Document&, DOM::QualifiedName);
 | |
| 
 | |
|     virtual void initialize(JS::Realm&) override;
 | |
| 
 | |
|     void run_activation_behavior(Web::DOM::Event const&);
 | |
| 
 | |
|     // ^DOM::Element
 | |
|     virtual void parse_attribute(DeprecatedFlyString const& name, DeprecatedString const& value) override;
 | |
|     virtual i32 default_tab_index_value() const override;
 | |
| 
 | |
|     // ^HTML::HTMLHyperlinkElementUtils
 | |
|     virtual DOM::Document& hyperlink_element_utils_document() override { return document(); }
 | |
|     virtual DeprecatedString hyperlink_element_utils_href() const override;
 | |
|     virtual void set_hyperlink_element_utils_href(DeprecatedString) override;
 | |
|     virtual bool hyperlink_element_utils_is_html_anchor_element() const final { return true; }
 | |
|     virtual bool hyperlink_element_utils_is_connected() const final { return is_connected(); }
 | |
|     virtual DeprecatedString hyperlink_element_utils_target() const final { return target(); }
 | |
|     virtual DeprecatedString hyperlink_element_utils_rel() const final { return rel(); }
 | |
|     virtual void hyperlink_element_utils_queue_an_element_task(HTML::Task::Source source, Function<void()> steps) override
 | |
|     {
 | |
|         queue_an_element_task(source, move(steps));
 | |
|     }
 | |
| 
 | |
|     virtual Optional<DOM::ARIARoles::Role> default_role() const override;
 | |
| };
 | |
| 
 | |
| }
 | |
| 
 | |
| namespace Web::DOM {
 | |
| template<>
 | |
| inline bool Node::fast_is<HTML::HTMLAnchorElement>() const { return is_html_anchor_element(); }
 | |
| }
 |