mirror of
				https://github.com/LadybirdBrowser/ladybird.git
				synced 2025-10-31 21:30:58 +00:00 
			
		
		
		
	 890b4d7980
			
		
	
	
		890b4d7980
		
	
	
	
	
		
			
			This replaces the FlyStrings for ARIA roles that were constructed in a [[gnu::constructor]] with a single enum. I came across this as the DOM inspector was crashing due to a null FlyString for an ARIA role. After fixing that, I was confused as to why these roles were not an enum. Looking at the spec there's a fixed list of roles and switching from references to static strings to an enum was pretty much an exercise in find and replace :). No functional changes (outside of fixing the mentioned crash).
		
			
				
	
	
		
			49 lines
		
	
	
	
		
			1.2 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			49 lines
		
	
	
	
		
			1.2 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
| /*
 | |
|  * Copyright (c) 2020-2022, the SerenityOS developers.
 | |
|  *
 | |
|  * SPDX-License-Identifier: BSD-2-Clause
 | |
|  */
 | |
| 
 | |
| #pragma once
 | |
| 
 | |
| #include <LibWeb/DOM/ARIARoles.h>
 | |
| #include <LibWeb/HTML/HTMLElement.h>
 | |
| 
 | |
| namespace Web::HTML {
 | |
| 
 | |
| class HTMLProgressElement final : public HTMLElement {
 | |
|     WEB_PLATFORM_OBJECT(HTMLProgressElement, HTMLElement);
 | |
| 
 | |
| public:
 | |
|     virtual ~HTMLProgressElement() override;
 | |
| 
 | |
|     virtual JS::GCPtr<Layout::Node> create_layout_node(NonnullRefPtr<CSS::StyleProperties>) override;
 | |
| 
 | |
|     double value() const;
 | |
|     void set_value(double);
 | |
| 
 | |
|     double max() const;
 | |
|     void set_max(double value);
 | |
| 
 | |
|     double position() const;
 | |
| 
 | |
|     // ^HTMLElement
 | |
|     // https://html.spec.whatwg.org/multipage/forms.html#category-label
 | |
|     virtual bool is_labelable() const override { return true; }
 | |
| 
 | |
|     bool using_system_appearance() const;
 | |
| 
 | |
|     // https://www.w3.org/TR/html-aria/#el-progress
 | |
|     virtual Optional<DOM::ARIARoles::Role> default_role() const override { return DOM::ARIARoles::Role::progressbar; }
 | |
| 
 | |
| private:
 | |
|     HTMLProgressElement(DOM::Document&, DOM::QualifiedName);
 | |
| 
 | |
|     virtual void initialize(JS::Realm&) override;
 | |
| 
 | |
|     void progress_position_updated();
 | |
| 
 | |
|     bool is_determinate() const { return has_attribute(HTML::AttributeNames::value); }
 | |
| };
 | |
| 
 | |
| }
 |