mirror of
				https://github.com/LadybirdBrowser/ladybird.git
				synced 2025-10-25 18:34:14 +00:00 
			
		
		
		
	 890b4d7980
			
		
	
	
		890b4d7980
		
	
	
	
	
		
			
			This replaces the FlyStrings for ARIA roles that were constructed in a [[gnu::constructor]] with a single enum. I came across this as the DOM inspector was crashing due to a null FlyString for an ARIA role. After fixing that, I was confused as to why these roles were not an enum. Looking at the spec there's a fixed list of roles and switching from references to static strings to an enum was pretty much an exercise in find and replace :). No functional changes (outside of fixing the mentioned crash).
		
			
				
	
	
		
			39 lines
		
	
	
	
		
			1 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			39 lines
		
	
	
	
		
			1 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
| /*
 | |
|  * Copyright (c) 2020, Andreas Kling <kling@serenityos.org>
 | |
|  *
 | |
|  * SPDX-License-Identifier: BSD-2-Clause
 | |
|  */
 | |
| 
 | |
| #pragma once
 | |
| 
 | |
| #include <LibWeb/DOM/ARIARoles.h>
 | |
| #include <LibWeb/HTML/HTMLElement.h>
 | |
| 
 | |
| namespace Web::HTML {
 | |
| 
 | |
| class HTMLTableRowElement final : public HTMLElement {
 | |
|     WEB_PLATFORM_OBJECT(HTMLTableRowElement, HTMLElement);
 | |
| 
 | |
| public:
 | |
|     virtual ~HTMLTableRowElement() override;
 | |
| 
 | |
|     JS::NonnullGCPtr<DOM::HTMLCollection> cells() const;
 | |
| 
 | |
|     int row_index() const;
 | |
|     int section_row_index() const;
 | |
|     WebIDL::ExceptionOr<JS::NonnullGCPtr<HTMLTableCellElement>> insert_cell(i32 index);
 | |
|     WebIDL::ExceptionOr<void> delete_cell(i32 index);
 | |
| 
 | |
|     // https://www.w3.org/TR/html-aria/#el-tr
 | |
|     virtual Optional<DOM::ARIARoles::Role> default_role() const override { return DOM::ARIARoles::Role::row; }
 | |
| 
 | |
| private:
 | |
|     HTMLTableRowElement(DOM::Document&, DOM::QualifiedName);
 | |
| 
 | |
|     virtual void initialize(JS::Realm&) override;
 | |
|     virtual void visit_edges(Cell::Visitor&) override;
 | |
| 
 | |
|     JS::GCPtr<DOM::HTMLCollection> mutable m_cells;
 | |
| };
 | |
| 
 | |
| }
 |