mirror of
				https://github.com/LadybirdBrowser/ladybird.git
				synced 2025-10-31 05:10:57 +00:00 
			
		
		
		
	 400aefb784
			
		
	
	
		400aefb784
		
	
	
	
	
		
			
			This fixes an issue where an SVGImageElement, whose source was a relative URL would not load inside an iframe.
		
			
				
	
	
		
			259 lines
		
	
	
	
		
			8.5 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			259 lines
		
	
	
	
		
			8.5 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
| /*
 | |
|  * Copyright (c) 2024-2025, Tim Ledbetter <tim.ledbetter@ladybird.org>
 | |
|  *
 | |
|  * SPDX-License-Identifier: BSD-2-Clause
 | |
|  */
 | |
| 
 | |
| #include "SVGImageElement.h"
 | |
| #include <LibCore/Timer.h>
 | |
| #include <LibGC/Heap.h>
 | |
| #include <LibWeb/Bindings/SVGImageElementPrototype.h>
 | |
| #include <LibWeb/DOM/DocumentObserver.h>
 | |
| #include <LibWeb/DOM/Event.h>
 | |
| #include <LibWeb/HTML/PotentialCORSRequest.h>
 | |
| #include <LibWeb/HTML/SharedResourceRequest.h>
 | |
| #include <LibWeb/Layout/SVGImageBox.h>
 | |
| #include <LibWeb/Painting/Paintable.h>
 | |
| #include <LibWeb/SVG/SVGDecodedImageData.h>
 | |
| 
 | |
| namespace Web::SVG {
 | |
| 
 | |
| SVGImageElement::SVGImageElement(DOM::Document& document, DOM::QualifiedName qualified_name)
 | |
|     : SVGGraphicsElement(document, move(qualified_name))
 | |
| {
 | |
|     m_animation_timer = Core::Timer::try_create().release_value_but_fixme_should_propagate_errors();
 | |
|     m_animation_timer->on_timeout = [this] { animate(); };
 | |
| }
 | |
| 
 | |
| void SVGImageElement::initialize(JS::Realm& realm)
 | |
| {
 | |
|     Base::initialize(realm);
 | |
|     WEB_SET_PROTOTYPE_FOR_INTERFACE(SVGImageElement);
 | |
| }
 | |
| 
 | |
| void SVGImageElement::visit_edges(Cell::Visitor& visitor)
 | |
| {
 | |
|     Base::visit_edges(visitor);
 | |
|     SVGURIReferenceMixin::visit_edges(visitor);
 | |
|     visitor.visit(m_x);
 | |
|     visitor.visit(m_y);
 | |
|     visitor.visit(m_width);
 | |
|     visitor.visit(m_height);
 | |
|     visitor.visit(m_resource_request);
 | |
| }
 | |
| 
 | |
| void SVGImageElement::attribute_changed(FlyString const& name, Optional<String> const& old_value, Optional<String> const& value, Optional<FlyString> const& namespace_)
 | |
| {
 | |
|     Base::attribute_changed(name, old_value, value, namespace_);
 | |
| 
 | |
|     if (name == SVG::AttributeNames::x) {
 | |
|         auto parsed_value = AttributeParser::parse_coordinate(value.value_or(String {}));
 | |
|         MUST(x()->base_val()->set_value(parsed_value.value_or(0)));
 | |
|     } else if (name == SVG::AttributeNames::y) {
 | |
|         auto parsed_value = AttributeParser::parse_coordinate(value.value_or(String {}));
 | |
|         MUST(y()->base_val()->set_value(parsed_value.value_or(0)));
 | |
|     } else if (name == SVG::AttributeNames::width) {
 | |
|         auto parsed_value = AttributeParser::parse_coordinate(value.value_or(String {}));
 | |
|         MUST(width()->base_val()->set_value(parsed_value.value_or(0)));
 | |
|     } else if (name == SVG::AttributeNames::height) {
 | |
|         auto parsed_value = AttributeParser::parse_coordinate(value.value_or(String {}));
 | |
|         MUST(height()->base_val()->set_value(parsed_value.value_or(0)));
 | |
|     } else if (name == SVG::AttributeNames::href) {
 | |
|         process_the_url(value);
 | |
|     }
 | |
| }
 | |
| 
 | |
| // https://svgwg.org/svg2-draft/embedded.html#__svg__SVGImageElement__x
 | |
| GC::Ref<SVG::SVGAnimatedLength> SVGImageElement::x()
 | |
| {
 | |
|     if (!m_x) {
 | |
|         auto& realm = this->realm();
 | |
|         m_x = SVGAnimatedLength::create(realm, SVGLength::create(realm, 0, 0), SVGLength::create(realm, 0, 0));
 | |
|     }
 | |
| 
 | |
|     return *m_x;
 | |
| }
 | |
| 
 | |
| // https://svgwg.org/svg2-draft/embedded.html#__svg__SVGImageElement__y
 | |
| GC::Ref<SVG::SVGAnimatedLength> SVGImageElement::y()
 | |
| {
 | |
|     if (!m_y) {
 | |
|         auto& realm = this->realm();
 | |
|         m_y = SVGAnimatedLength::create(realm, SVGLength::create(realm, 0, 0), SVGLength::create(realm, 0, 0));
 | |
|     }
 | |
| 
 | |
|     return *m_y;
 | |
| }
 | |
| 
 | |
| // https://svgwg.org/svg2-draft/embedded.html#__svg__SVGImageElement__width
 | |
| GC::Ref<SVG::SVGAnimatedLength> SVGImageElement::width()
 | |
| {
 | |
|     if (!m_width) {
 | |
|         auto& realm = this->realm();
 | |
|         m_width = SVGAnimatedLength::create(realm, SVGLength::create(realm, 0, intrinsic_width().value_or(0).to_double()), SVGLength::create(realm, 0, 0));
 | |
|     }
 | |
| 
 | |
|     return *m_width;
 | |
| }
 | |
| 
 | |
| // https://svgwg.org/svg2-draft/embedded.html#__svg__SVGImageElement__height
 | |
| GC::Ref<SVG::SVGAnimatedLength> SVGImageElement::height()
 | |
| {
 | |
|     if (!m_height) {
 | |
|         auto& realm = this->realm();
 | |
|         m_height = SVGAnimatedLength::create(realm, SVGLength::create(realm, 0, intrinsic_height().value_or(0).to_double()), SVGLength::create(realm, 0, 0));
 | |
|     }
 | |
| 
 | |
|     return *m_height;
 | |
| }
 | |
| 
 | |
| Gfx::Rect<CSSPixels> SVGImageElement::bounding_box() const
 | |
| {
 | |
|     Optional<CSSPixels> width;
 | |
|     if (attribute(HTML::AttributeNames::width).has_value())
 | |
|         width = CSSPixels { m_width->base_val()->value() };
 | |
| 
 | |
|     Optional<CSSPixels> height;
 | |
|     if (attribute(HTML::AttributeNames::height).has_value())
 | |
|         height = CSSPixels { m_height->base_val()->value() };
 | |
| 
 | |
|     if (!height.has_value() && width.has_value() && intrinsic_aspect_ratio().has_value())
 | |
|         height = width.value() / intrinsic_aspect_ratio().value();
 | |
| 
 | |
|     if (!width.has_value() && height.has_value() && intrinsic_aspect_ratio().has_value())
 | |
|         width = height.value() * intrinsic_aspect_ratio().value();
 | |
| 
 | |
|     if (!width.has_value() && intrinsic_width().has_value())
 | |
|         width = intrinsic_width();
 | |
| 
 | |
|     if (!height.has_value() && intrinsic_height().has_value())
 | |
|         height = intrinsic_height();
 | |
| 
 | |
|     return {
 | |
|         CSSPixels { m_x ? m_x->base_val()->value() : 0 },
 | |
|         CSSPixels { m_y ? m_y->base_val()->value() : 0 },
 | |
|         width.value_or(0),
 | |
|         height.value_or(0),
 | |
|     };
 | |
| }
 | |
| 
 | |
| // https://www.w3.org/TR/SVG2/linking.html#processingURL
 | |
| void SVGImageElement::process_the_url(Optional<String> const& href)
 | |
| {
 | |
|     if (!href.has_value()) {
 | |
|         m_href = {};
 | |
|         return;
 | |
|     }
 | |
| 
 | |
|     m_href = document().parse_url(*href);
 | |
| 
 | |
|     if (!m_href.is_valid())
 | |
|         return;
 | |
| 
 | |
|     fetch_the_document(m_href);
 | |
| }
 | |
| 
 | |
| // https://svgwg.org/svg2-draft/linking.html#processingURL-fetch
 | |
| void SVGImageElement::fetch_the_document(URL::URL const& url)
 | |
| {
 | |
|     m_load_event_delayer.emplace(document());
 | |
|     m_resource_request = HTML::SharedResourceRequest::get_or_create(realm(), document().page(), url);
 | |
|     m_resource_request->add_callbacks(
 | |
|         [this] {
 | |
|             m_load_event_delayer.clear();
 | |
|             auto image_data = m_resource_request->image_data();
 | |
|             if (image_data->is_animated() && image_data->frame_count() > 1) {
 | |
|                 m_current_frame_index = 0;
 | |
|                 m_animation_timer->set_interval(image_data->frame_duration(0));
 | |
|                 m_animation_timer->start();
 | |
|             }
 | |
|             set_needs_style_update(true);
 | |
|             document().set_needs_layout();
 | |
| 
 | |
|             dispatch_event(DOM::Event::create(realm(), HTML::EventNames::load));
 | |
|         },
 | |
|         [this] {
 | |
|             m_load_event_delayer.clear();
 | |
| 
 | |
|             dispatch_event(DOM::Event::create(realm(), HTML::EventNames::error));
 | |
|         });
 | |
| 
 | |
|     if (m_resource_request->needs_fetching()) {
 | |
|         auto request = HTML::create_potential_CORS_request(vm(), url, Fetch::Infrastructure::Request::Destination::Image, HTML::CORSSettingAttribute::NoCORS);
 | |
|         request->set_client(&document().relevant_settings_object());
 | |
|         m_resource_request->fetch_resource(realm(), request);
 | |
|     }
 | |
| }
 | |
| 
 | |
| GC::Ptr<Layout::Node> SVGImageElement::create_layout_node(GC::Ref<CSS::ComputedProperties> style)
 | |
| {
 | |
|     return heap().allocate<Layout::SVGImageBox>(document(), *this, move(style));
 | |
| }
 | |
| 
 | |
| bool SVGImageElement::is_image_available() const
 | |
| {
 | |
|     return m_resource_request && m_resource_request->image_data();
 | |
| }
 | |
| 
 | |
| Optional<CSSPixels> SVGImageElement::intrinsic_width() const
 | |
| {
 | |
|     if (!m_resource_request)
 | |
|         return {};
 | |
|     if (auto image_data = m_resource_request->image_data())
 | |
|         return image_data->intrinsic_width();
 | |
|     return {};
 | |
| }
 | |
| 
 | |
| Optional<CSSPixels> SVGImageElement::intrinsic_height() const
 | |
| {
 | |
|     if (!m_resource_request)
 | |
|         return {};
 | |
|     if (auto image_data = m_resource_request->image_data())
 | |
|         return image_data->intrinsic_height();
 | |
|     return {};
 | |
| }
 | |
| 
 | |
| Optional<CSSPixelFraction> SVGImageElement::intrinsic_aspect_ratio() const
 | |
| {
 | |
|     if (!m_resource_request)
 | |
|         return {};
 | |
|     if (auto image_data = m_resource_request->image_data())
 | |
|         return image_data->intrinsic_aspect_ratio();
 | |
|     return {};
 | |
| }
 | |
| 
 | |
| RefPtr<Gfx::ImmutableBitmap> SVGImageElement::current_image_bitmap(Gfx::IntSize size) const
 | |
| {
 | |
|     if (!m_resource_request)
 | |
|         return {};
 | |
|     if (auto data = m_resource_request->image_data())
 | |
|         return data->bitmap(m_current_frame_index, size);
 | |
|     return {};
 | |
| }
 | |
| 
 | |
| void SVGImageElement::animate()
 | |
| {
 | |
|     auto image_data = m_resource_request->image_data();
 | |
|     if (!image_data) {
 | |
|         return;
 | |
|     }
 | |
| 
 | |
|     m_current_frame_index = (m_current_frame_index + 1) % image_data->frame_count();
 | |
|     auto current_frame_duration = image_data->frame_duration(m_current_frame_index);
 | |
| 
 | |
|     if (current_frame_duration != m_animation_timer->interval()) {
 | |
|         m_animation_timer->restart(current_frame_duration);
 | |
|     }
 | |
| 
 | |
|     if (m_current_frame_index == image_data->frame_count() - 1) {
 | |
|         ++m_loops_completed;
 | |
|         if (m_loops_completed > 0 && m_loops_completed == image_data->loop_count()) {
 | |
|             m_animation_timer->stop();
 | |
|         }
 | |
|     }
 | |
| 
 | |
|     if (paintable())
 | |
|         paintable()->set_needs_display();
 | |
| }
 | |
| 
 | |
| }
 |