mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2026-06-17 15:25:35 +00:00
DecodedImageData::paint() used to take both a destination and a clip rectangle even though most callers passed the same value. SVG image painting used that API to wrap every nested SVG display list in save/add-clip/restore, which put an unbounded command in front of the bounded nested-list command and made offscreen SVG image content harder to cull. Move clipping to ImagePaintable, where the object-fit destination can be compared with the replaced element box. CSS image and marker painting continue to draw into their destination rect, while repeated background images keep their explicit tile clip. The scaled decoded image display-list command now stores only its destination rect and uses that as its bounds; playback still clips decoded images to that rect so bitmap rendering stays unchanged.
52 lines
1.7 KiB
C++
52 lines
1.7 KiB
C++
/*
|
|
* Copyright (c) 2023, Andreas Kling <andreas@ladybird.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <LibGfx/DecodedImageFrame.h>
|
|
#include <LibGfx/Forward.h>
|
|
#include <LibWeb/HTML/DecodedImageData.h>
|
|
|
|
namespace Web::HTML {
|
|
|
|
class BitmapDecodedImageData final : public DecodedImageData {
|
|
GC_CELL(BitmapDecodedImageData, DecodedImageData);
|
|
GC_DECLARE_ALLOCATOR(BitmapDecodedImageData);
|
|
|
|
public:
|
|
struct Frame {
|
|
Gfx::DecodedImageFrame frame;
|
|
int duration { 0 };
|
|
};
|
|
|
|
static ErrorOr<GC::Ref<BitmapDecodedImageData>> create(JS::Realm&, Vector<Frame>&&, size_t loop_count, bool animated);
|
|
virtual ~BitmapDecodedImageData() override;
|
|
|
|
virtual Optional<Gfx::DecodedImageFrame> frame(size_t frame_index, Gfx::IntSize = {}) const override;
|
|
virtual int frame_duration(size_t frame_index) const override;
|
|
|
|
virtual size_t frame_count() const override { return m_frames.size(); }
|
|
virtual size_t loop_count() const override { return m_loop_count; }
|
|
virtual bool is_animated() const override { return m_animated; }
|
|
|
|
virtual Optional<CSSPixels> intrinsic_width() const override;
|
|
virtual Optional<CSSPixels> intrinsic_height() const override;
|
|
virtual Optional<CSSPixelFraction> intrinsic_aspect_ratio() const override;
|
|
|
|
virtual Optional<Gfx::IntRect> frame_rect(size_t frame_index) const override;
|
|
virtual void paint(DisplayListRecordingContext&, size_t frame_index, Gfx::IntRect dst_rect, Gfx::ScalingMode scaling_mode) const override;
|
|
|
|
private:
|
|
BitmapDecodedImageData(Vector<Frame>&&, size_t loop_count, bool animated);
|
|
|
|
virtual size_t external_memory_size() const override;
|
|
|
|
Vector<Frame> m_frames;
|
|
size_t m_loop_count { 0 };
|
|
bool m_animated { false };
|
|
};
|
|
|
|
}
|