ladybird/Libraries/LibWeb/ResizeObserver/ResizeObserver.cpp
Andreas Kling a36f8aa36d LibWeb: Keep ResizeObserver targets weakly
Store ResizeObservation targets weakly, matching Blink and WebKit. A
ResizeObserver can be kept alive by the document while it has observed
targets, but the observation itself should not keep a removed target and
its subtree alive forever.

Prune dead observations before gathering active resize observations.
Snapshot the document observer list before pruning so unregistering an
observer cannot mutate the intrusive list being iterated. Keep gathered
active targets rooted while broadcasting callbacks, since an earlier
callback can remove a later target and trigger GC before delivery.

Expose an internals helper to force environment-bound test objects to be
treated as garbage. Add text coverage for both pruning a dead observer
during gather and GC during an earlier resize observer callback.
2026-05-16 18:48:52 +02:00

155 lines
5.2 KiB
C++

/*
* Copyright (c) 2021, Andreas Kling <andreas@ladybird.org>
* Copyright (c) 2024-2025, Aliaksandr Kalenik <kalenik.aliaksandr@gmail.com>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#include <LibWeb/Bindings/Intrinsics.h>
#include <LibWeb/Bindings/ResizeObserver.h>
#include <LibWeb/DOM/Document.h>
#include <LibWeb/HTML/Scripting/ExceptionReporter.h>
#include <LibWeb/HTML/Window.h>
#include <LibWeb/Page/Page.h>
#include <LibWeb/ResizeObserver/ResizeObserver.h>
#include <LibWeb/WebIDL/AbstractOperations.h>
namespace Web::ResizeObserver {
GC_DEFINE_ALLOCATOR(ResizeObserver);
// https://drafts.csswg.org/resize-observer/#dom-resizeobserver-resizeobserver
WebIDL::ExceptionOr<GC::Ref<ResizeObserver>> ResizeObserver::construct_impl(JS::Realm& realm, WebIDL::CallbackType* callback)
{
return realm.create<ResizeObserver>(realm, callback);
}
ResizeObserver::ResizeObserver(JS::Realm& realm, WebIDL::CallbackType* callback)
: PlatformObject(realm)
, m_callback(callback)
{
m_document = as<HTML::Window>(HTML::relevant_global_object(*this)).document().ptr();
}
ResizeObserver::~ResizeObserver() = default;
void ResizeObserver::initialize(JS::Realm& realm)
{
WEB_SET_PROTOTYPE_FOR_INTERFACE(ResizeObserver);
Base::initialize(realm);
}
void ResizeObserver::visit_edges(JS::Cell::Visitor& visitor)
{
Base::visit_edges(visitor);
visitor.visit(m_callback);
visitor.visit(m_observation_targets);
visitor.visit(m_active_targets);
visitor.visit(m_skipped_targets);
}
void ResizeObserver::finalize()
{
Base::finalize();
if (m_document && m_list_node.is_in_list())
m_document->unregister_resize_observer({}, *this);
}
// https://drafts.csswg.org/resize-observer-1/#dom-resizeobserver-observe
void ResizeObserver::observe(DOM::Element& target, Bindings::ResizeObserverOptions options)
{
// 1. If target is in [[observationTargets]] slot, call unobserve() with argument target.
auto observation = m_observation_targets.find_if([&](auto& observation) { return observation->target().ptr() == &target; });
if (!observation.is_end())
unobserve(target);
// 2. Let observedBox be the value of the box dictionary member of options.
auto observed_box = options.box;
// 3. Let resizeObservation be new ResizeObservation(target, observedBox).
auto resize_observation = MUST(ResizeObservation::create(realm(), target, observed_box));
// 4. Add the resizeObservation to the [[observationTargets]] slot.
m_observation_targets.append(resize_observation);
if (!m_list_node.is_in_list()) {
m_document->register_resize_observer({}, *this);
}
m_document->page().client().request_frame();
}
// https://drafts.csswg.org/resize-observer-1/#dom-resizeobserver-unobserve
void ResizeObserver::unobserve(DOM::Element& target)
{
// 1. Let observation be ResizeObservation in [[observationTargets]] whose target slot is target.
auto observation = m_observation_targets.find_if([&](auto& observation) { return observation->target().ptr() == &target; });
// 2. If observation is not found, return.
if (observation.is_end())
return;
// 3. Remove observation from [[observationTargets]].
m_observation_targets.remove(observation.index());
unregister_observer_if_needed();
}
// https://drafts.csswg.org/resize-observer-1/#dom-resizeobserver-disconnect
void ResizeObserver::disconnect()
{
// 1. Clear the [[observationTargets]] list.
m_observation_targets.clear();
// 2. Clear the [[activeTargets]] list.
m_active_targets.clear();
unregister_observer_if_needed();
}
void ResizeObserver::remove_dead_observations()
{
m_observation_targets.remove_all_matching([](auto& observation) {
return !observation->target();
});
m_active_targets.remove_all_matching([](auto& observation) {
return !observation->target();
});
m_skipped_targets.remove_all_matching([](auto& observation) {
return !observation->target();
});
unregister_observer_if_needed();
}
void ResizeObserver::invoke_callback(ReadonlySpan<GC::Ref<ResizeObserverEntry>> entries) const
{
auto& callback = *m_callback;
auto& settings_object = callback.callback_context;
auto wrapped_records = MUST(JS::Array::create(settings_object->realm(), 0));
for (size_t i = 0; i < entries.size(); ++i) {
auto& record = entries.at(i);
auto property_index = JS::PropertyKey { i };
MUST(wrapped_records->create_data_property(property_index, record.ptr()));
}
(void)WebIDL::invoke_callback(callback, this, WebIDL::ExceptionBehavior::Report, { { wrapped_records, this } });
}
void ResizeObserver::unregister_observer_if_needed()
{
// https://drafts.csswg.org/resize-observer/#lifetime
// A ResizeObserver will remain alive until both of these conditions are met:
// - there are no scripting references to the observer.
// - the observer is not observing any targets.
// The first condition from the spec is handled by visiting ResizeObserver from
// JS environment that holds a reference to ResizeObserver.
// Here we handle the second condition.
if (m_observation_targets.is_empty() && m_list_node.is_in_list() && m_document) {
m_document->unregister_resize_observer({}, *this);
}
}
}