mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2026-04-18 18:00:31 +00:00
ce81f16530
With apply_to() now self-contained (carrying its own replacement DocumentState rather than reading from the live entry), the clone at the traversal call site is no longer needed. The clone previously served two purposes: 1. Input snapshot: freeze entry fields before deferred population. Now solved by changing populate_session_history_entry_document() to take explicit input parameters, snapshotted before the deferred_invoke. 2. Output isolation: absorb apply_to() and post-population adjustments without mutating the live entry during unload. Now solved by storing the PopulateSessionHistoryEntryDocumentOutput on the continuation state and deferring all mutations (including the origin-based classic_history_api_state reset and navigable_target_name clear) to after_potential_unload. The post-population adjustments run unconditionally in after_potential_unload, covering both the population path and the non-population path (e.g. traversal to an already-populated error entry).
42 lines
1.3 KiB
C++
42 lines
1.3 KiB
C++
/*
|
|
* Copyright (c) 2022, Andreas Kling <andreas@ladybird.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <LibWeb/Crypto/Crypto.h>
|
|
#include <LibWeb/HTML/BrowsingContext.h>
|
|
#include <LibWeb/HTML/DocumentState.h>
|
|
#include <LibWeb/HTML/SessionHistoryEntry.h>
|
|
#include <LibWeb/HTML/StructuredSerialize.h>
|
|
|
|
namespace Web::HTML {
|
|
|
|
GC_DEFINE_ALLOCATOR(SessionHistoryEntry);
|
|
|
|
void SessionHistoryEntry::visit_edges(Cell::Visitor& visitor)
|
|
{
|
|
Base::visit_edges(visitor);
|
|
visitor.visit(m_document_state);
|
|
visitor.visit(m_original_source_browsing_context);
|
|
visitor.visit(m_policy_container);
|
|
}
|
|
|
|
SessionHistoryEntry::SessionHistoryEntry()
|
|
: m_classic_history_api_state(MUST(structured_serialize_for_storage(vm(), JS::js_null())))
|
|
, m_navigation_api_state(MUST(structured_serialize_for_storage(vm(), JS::js_undefined())))
|
|
, m_navigation_api_key(Crypto::generate_random_uuid())
|
|
, m_navigation_api_id(Crypto::generate_random_uuid())
|
|
{
|
|
}
|
|
|
|
// https://html.spec.whatwg.org/multipage/browsing-the-web.html#she-document
|
|
GC::Ptr<DOM::Document> SessionHistoryEntry::document() const
|
|
{
|
|
// To get a session history entry's document, return its document state's document.
|
|
if (!m_document_state)
|
|
return {};
|
|
return m_document_state->document();
|
|
}
|
|
|
|
}
|