mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-11-04 07:10:57 +00:00
570814a31e
This change makes all the pre-commit CI scripts runnable under Bash 3.2, by replacing “mapfile” invocations in them code that first explicitly creates an array, and then uses a while loop to populate the array. Otherwise, without this change, the scripts all fail to run under Bash 3.2 — due to lack of support for “mapfile”. Fixes https://github.com/LadybirdBrowser/ladybird/issues/283 This also drops bash from the list of homebrew dependencies in the build instructions — because with this change, homebrew bash (v4) is no longer needed; things will now work with the Apple-provided bash (v3.2)
48 lines
1.3 KiB
Bash
Executable file
48 lines
1.3 KiB
Bash
Executable file
#!/usr/bin/env bash
|
|
|
|
set -eo pipefail
|
|
|
|
script_path=$(cd -P -- "$(dirname -- "$0")" && pwd -P)
|
|
cd "$script_path/.."
|
|
|
|
if [ "$#" -eq "0" ]; then
|
|
files=()
|
|
while IFS= read -r file; do
|
|
files+=("$file")
|
|
done < <(
|
|
git ls-files -- \
|
|
'*.sh' \
|
|
)
|
|
else
|
|
files=()
|
|
for file in "$@"; do
|
|
# Skip ports, like we in the CI case above.
|
|
if [[ "${file}" =~ "Ports" ]]; then
|
|
continue
|
|
fi
|
|
|
|
if [[ "${file}" == *".sh" && "${file}" != "Base/root/generate_manpages.sh" ]]; then
|
|
files+=("${file}")
|
|
fi
|
|
done
|
|
fi
|
|
|
|
if (( ${#files[@]} )); then
|
|
if ! command -v shellcheck &>/dev/null ; then
|
|
echo "shellcheck is not available, but shell files need linting! Either skip this script, or install shellcheck."
|
|
exit 1
|
|
fi
|
|
|
|
shellcheck --source-path=SCRIPTDIR "${files[@]}"
|
|
|
|
for file in "${files[@]}"; do
|
|
if (< "$file" grep -qE "grep [^|);]*-[^- ]*P"); then
|
|
# '\x2D' is the unicode escape sequence for '-'. This is used so
|
|
# that this script does not flag itself for containing grep dash P.
|
|
echo -e "The script '$file' contains 'grep \x2DP', which is not supported on macOS. Please use grep -E instead."
|
|
exit 1
|
|
fi
|
|
done
|
|
else
|
|
echo "No .sh files to check."
|
|
fi
|