ladybird/Libraries/LibWeb/HTML/NavigationObserver.h
Aliaksandr Kalenik ed9c0c1e09 LibWeb: Don't visit registered NavigationObserver from Navigable
NavigationObserver register itself in Navigable from constructor and
unregister itself from `finalize()`. The problem is that `finalize()`
won't be invoked for as long as NavigationObserver is visited by
Navigable, leading to GC leaks.
2025-11-07 04:08:30 +01:00

39 lines
1 KiB
C++

/*
* Copyright (c) 2024, Tim Flynn <trflynn89@ladybird.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#pragma once
#include <LibGC/Function.h>
#include <LibGC/Ptr.h>
#include <LibWeb/Bindings/PlatformObject.h>
#include <LibWeb/Export.h>
#include <LibWeb/Forward.h>
namespace Web::HTML {
class WEB_API NavigationObserver final : public Bindings::PlatformObject {
WEB_PLATFORM_OBJECT(NavigationObserver, Bindings::PlatformObject);
GC_DECLARE_ALLOCATOR(NavigationObserver);
public:
[[nodiscard]] GC::Ptr<GC::Function<void()>> navigation_complete() const { return m_navigation_complete; }
void set_navigation_complete(Function<void()>);
private:
NavigationObserver(JS::Realm&, Navigable&);
virtual void visit_edges(Cell::Visitor&) override;
virtual void finalize() override;
IntrusiveListNode<NavigationObserver> m_list_node;
GC::Ref<Navigable> m_navigable;
GC::Ptr<GC::Function<void()>> m_navigation_complete;
public:
using NavigationObserversList = IntrusiveList<&NavigationObserver::m_list_node>;
};
}