mirror of
				https://github.com/LadybirdBrowser/ladybird.git
				synced 2025-11-03 23:00:58 +00:00 
			
		
		
		
	Currently, integers are stored in LibSQL as 32-bit signed integers, even if the provided type is unsigned. This resulted in a series of unchecked unsigned-to-signed conversions, and prevented storing 64-bit values. Further, mathematical operations were performed without similar checks, and without checking for overflow. This changes SQL::Value to behave like SQLite for INTEGER types. In SQLite, the INTEGER type does not imply a size or signedness of the underlying type. Instead, SQLite determines on-the-fly what type is needed as values are created and updated. To do so, the SQL::Value variant can now hold an i64 or u64 integer. If a specific type is requested, invalid conversions are now explictly an error (e.g. converting a stored -1 to a u64 will fail). When binary mathematical operations are performed, we now try to coerce the RHS value to a type that works with the LHS value, failing the operation if that isn't possible. Any overflow or invalid operation (e.g. bitshifting a 64-bit value by more than 64 bytes) is an error.
		
			
				
	
	
		
			214 lines
		
	
	
	
		
			5.7 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			214 lines
		
	
	
	
		
			5.7 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
/*
 | 
						|
 * Copyright (c) 2021, Jan de Visser <jan@de-visser.net>
 | 
						|
 *
 | 
						|
 * SPDX-License-Identifier: BSD-2-Clause
 | 
						|
 */
 | 
						|
 | 
						|
#include <LibSQL/Key.h>
 | 
						|
#include <LibSQL/Meta.h>
 | 
						|
#include <LibSQL/Type.h>
 | 
						|
 | 
						|
namespace SQL {
 | 
						|
 | 
						|
u32 Relation::hash() const
 | 
						|
{
 | 
						|
    return key().hash();
 | 
						|
}
 | 
						|
 | 
						|
SchemaDef::SchemaDef(DeprecatedString name)
 | 
						|
    : Relation(move(name))
 | 
						|
{
 | 
						|
}
 | 
						|
 | 
						|
SchemaDef::SchemaDef(Key const& key)
 | 
						|
    : Relation(key["schema_name"].to_deprecated_string())
 | 
						|
{
 | 
						|
}
 | 
						|
 | 
						|
Key SchemaDef::key() const
 | 
						|
{
 | 
						|
    auto key = Key(index_def()->to_tuple_descriptor());
 | 
						|
    key["schema_name"] = name();
 | 
						|
    key.set_pointer(pointer());
 | 
						|
    return key;
 | 
						|
}
 | 
						|
 | 
						|
Key SchemaDef::make_key()
 | 
						|
{
 | 
						|
    return Key(index_def());
 | 
						|
}
 | 
						|
 | 
						|
NonnullRefPtr<IndexDef> SchemaDef::index_def()
 | 
						|
{
 | 
						|
    NonnullRefPtr<IndexDef> s_index_def = IndexDef::construct("$schema", true, 0);
 | 
						|
    if (!s_index_def->size()) {
 | 
						|
        s_index_def->append_column("schema_name", SQLType::Text, Order::Ascending);
 | 
						|
    }
 | 
						|
    return s_index_def;
 | 
						|
}
 | 
						|
 | 
						|
ColumnDef::ColumnDef(Relation* parent, size_t column_number, DeprecatedString name, SQLType sql_type)
 | 
						|
    : Relation(move(name), parent)
 | 
						|
    , m_index(column_number)
 | 
						|
    , m_type(sql_type)
 | 
						|
    , m_default(Value(sql_type))
 | 
						|
{
 | 
						|
}
 | 
						|
 | 
						|
Key ColumnDef::key() const
 | 
						|
{
 | 
						|
    auto key = Key(index_def());
 | 
						|
    key["table_hash"] = parent_relation()->hash();
 | 
						|
    key["column_number"] = column_number();
 | 
						|
    key["column_name"] = name();
 | 
						|
    key["column_type"] = to_underlying(type());
 | 
						|
    return key;
 | 
						|
}
 | 
						|
 | 
						|
void ColumnDef::set_default_value(Value const& default_value)
 | 
						|
{
 | 
						|
    VERIFY(default_value.type() == type());
 | 
						|
    m_default = default_value;
 | 
						|
}
 | 
						|
 | 
						|
Key ColumnDef::make_key(TableDef const& table_def)
 | 
						|
{
 | 
						|
    Key key(index_def());
 | 
						|
    key["table_hash"] = table_def.key().hash();
 | 
						|
    return key;
 | 
						|
}
 | 
						|
 | 
						|
NonnullRefPtr<IndexDef> ColumnDef::index_def()
 | 
						|
{
 | 
						|
    NonnullRefPtr<IndexDef> s_index_def = IndexDef::construct("$column", true, 0);
 | 
						|
    if (!s_index_def->size()) {
 | 
						|
        s_index_def->append_column("table_hash", SQLType::Integer, Order::Ascending);
 | 
						|
        s_index_def->append_column("column_number", SQLType::Integer, Order::Ascending);
 | 
						|
        s_index_def->append_column("column_name", SQLType::Text, Order::Ascending);
 | 
						|
        s_index_def->append_column("column_type", SQLType::Integer, Order::Ascending);
 | 
						|
    }
 | 
						|
    return s_index_def;
 | 
						|
}
 | 
						|
 | 
						|
KeyPartDef::KeyPartDef(IndexDef* index, DeprecatedString name, SQLType sql_type, Order sort_order)
 | 
						|
    : ColumnDef(index, index->size(), move(name), sql_type)
 | 
						|
    , m_sort_order(sort_order)
 | 
						|
{
 | 
						|
}
 | 
						|
 | 
						|
IndexDef::IndexDef(TableDef* table, DeprecatedString name, bool unique, u32 pointer)
 | 
						|
    : Relation(move(name), pointer, table)
 | 
						|
    , m_key_definition()
 | 
						|
    , m_unique(unique)
 | 
						|
{
 | 
						|
}
 | 
						|
 | 
						|
IndexDef::IndexDef(DeprecatedString name, bool unique, u32 pointer)
 | 
						|
    : IndexDef(nullptr, move(name), unique, pointer)
 | 
						|
{
 | 
						|
}
 | 
						|
 | 
						|
void IndexDef::append_column(DeprecatedString name, SQLType sql_type, Order sort_order)
 | 
						|
{
 | 
						|
    auto part = KeyPartDef::construct(this, move(name), sql_type, sort_order);
 | 
						|
    m_key_definition.append(part);
 | 
						|
}
 | 
						|
 | 
						|
NonnullRefPtr<TupleDescriptor> IndexDef::to_tuple_descriptor() const
 | 
						|
{
 | 
						|
    NonnullRefPtr<TupleDescriptor> ret = adopt_ref(*new TupleDescriptor);
 | 
						|
    for (auto& part : m_key_definition) {
 | 
						|
        ret->append({ "", "", part.name(), part.type(), part.sort_order() });
 | 
						|
    }
 | 
						|
    return ret;
 | 
						|
}
 | 
						|
 | 
						|
Key IndexDef::key() const
 | 
						|
{
 | 
						|
    auto key = Key(index_def()->to_tuple_descriptor());
 | 
						|
    key["table_hash"] = parent_relation()->key().hash();
 | 
						|
    key["index_name"] = name();
 | 
						|
    key["unique"] = unique() ? 1 : 0;
 | 
						|
    return key;
 | 
						|
}
 | 
						|
 | 
						|
Key IndexDef::make_key(TableDef const& table_def)
 | 
						|
{
 | 
						|
    Key key(index_def());
 | 
						|
    key["table_hash"] = table_def.key().hash();
 | 
						|
    return key;
 | 
						|
}
 | 
						|
 | 
						|
NonnullRefPtr<IndexDef> IndexDef::index_def()
 | 
						|
{
 | 
						|
    NonnullRefPtr<IndexDef> s_index_def = IndexDef::construct("$index", true, 0);
 | 
						|
    if (!s_index_def->size()) {
 | 
						|
        s_index_def->append_column("table_hash", SQLType::Integer, Order::Ascending);
 | 
						|
        s_index_def->append_column("index_name", SQLType::Text, Order::Ascending);
 | 
						|
        s_index_def->append_column("unique", SQLType::Integer, Order::Ascending);
 | 
						|
    }
 | 
						|
    return s_index_def;
 | 
						|
}
 | 
						|
 | 
						|
TableDef::TableDef(SchemaDef* schema, DeprecatedString name)
 | 
						|
    : Relation(move(name), schema)
 | 
						|
    , m_columns()
 | 
						|
    , m_indexes()
 | 
						|
{
 | 
						|
}
 | 
						|
 | 
						|
NonnullRefPtr<TupleDescriptor> TableDef::to_tuple_descriptor() const
 | 
						|
{
 | 
						|
    NonnullRefPtr<TupleDescriptor> ret = adopt_ref(*new TupleDescriptor);
 | 
						|
    for (auto& part : m_columns) {
 | 
						|
        ret->append({ parent()->name(), name(), part.name(), part.type(), Order::Ascending });
 | 
						|
    }
 | 
						|
    return ret;
 | 
						|
}
 | 
						|
 | 
						|
Key TableDef::key() const
 | 
						|
{
 | 
						|
    auto key = Key(index_def()->to_tuple_descriptor());
 | 
						|
    key["schema_hash"] = parent_relation()->key().hash();
 | 
						|
    key["table_name"] = name();
 | 
						|
    key.set_pointer(pointer());
 | 
						|
    return key;
 | 
						|
}
 | 
						|
 | 
						|
void TableDef::append_column(DeprecatedString name, SQLType sql_type)
 | 
						|
{
 | 
						|
    auto column = ColumnDef::construct(this, num_columns(), move(name), sql_type);
 | 
						|
    m_columns.append(column);
 | 
						|
}
 | 
						|
 | 
						|
void TableDef::append_column(Key const& column)
 | 
						|
{
 | 
						|
    auto column_type = column["column_type"].to_int<UnderlyingType<SQLType>>();
 | 
						|
    VERIFY(column_type.has_value());
 | 
						|
 | 
						|
    append_column(column["column_name"].to_deprecated_string(), static_cast<SQLType>(*column_type));
 | 
						|
}
 | 
						|
 | 
						|
Key TableDef::make_key(SchemaDef const& schema_def)
 | 
						|
{
 | 
						|
    return TableDef::make_key(schema_def.key());
 | 
						|
}
 | 
						|
 | 
						|
Key TableDef::make_key(Key const& schema_key)
 | 
						|
{
 | 
						|
    Key key(index_def());
 | 
						|
    key["schema_hash"] = schema_key.hash();
 | 
						|
    return key;
 | 
						|
}
 | 
						|
 | 
						|
NonnullRefPtr<IndexDef> TableDef::index_def()
 | 
						|
{
 | 
						|
    NonnullRefPtr<IndexDef> s_index_def = IndexDef::construct("$table", true, 0);
 | 
						|
    if (!s_index_def->size()) {
 | 
						|
        s_index_def->append_column("schema_hash", SQLType::Integer, Order::Ascending);
 | 
						|
        s_index_def->append_column("table_name", SQLType::Text, Order::Ascending);
 | 
						|
    }
 | 
						|
    return s_index_def;
 | 
						|
}
 | 
						|
 | 
						|
}
 |