mirror of
				https://github.com/LadybirdBrowser/ladybird.git
				synced 2025-10-31 13:20:59 +00:00 
			
		
		
		
	 41a3c19cfe
			
		
	
	
		41a3c19cfe
		
	
	
	
	
		
			
			This change fixes GC-leak caused by following mutual dependency: - SVGDecodedImageData owns JS::Handle for Page. - SVGDecodedImageData is owned by visited objects. by making everything inherited from HTML::DecodedImageData and ListOfAvailableImages to be GC-allocated. Generally, if visited object has a handle, very likely we leak everything visited from object in a handle.
		
			
				
	
	
		
			96 lines
		
	
	
	
		
			3.4 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			96 lines
		
	
	
	
		
			3.4 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
| /*
 | |
|  * Copyright (c) 2023, Andreas Kling <kling@serenityos.org>
 | |
|  *
 | |
|  * SPDX-License-Identifier: BSD-2-Clause
 | |
|  */
 | |
| 
 | |
| #pragma once
 | |
| 
 | |
| #include <AK/Error.h>
 | |
| #include <AK/OwnPtr.h>
 | |
| #include <AK/URL.h>
 | |
| #include <LibGfx/Size.h>
 | |
| #include <LibJS/Heap/Handle.h>
 | |
| #include <LibWeb/Forward.h>
 | |
| #include <LibWeb/HTML/SharedImageRequest.h>
 | |
| 
 | |
| namespace Web::HTML {
 | |
| 
 | |
| // https://html.spec.whatwg.org/multipage/images.html#image-request
 | |
| class ImageRequest final : public JS::Cell {
 | |
|     JS_CELL(ImageRequest, JS::Cell);
 | |
|     JS_DECLARE_ALLOCATOR(ImageRequest);
 | |
| 
 | |
| public:
 | |
|     [[nodiscard]] static JS::NonnullGCPtr<ImageRequest> create(JS::Realm&, JS::NonnullGCPtr<Page>);
 | |
| 
 | |
|     ~ImageRequest();
 | |
| 
 | |
|     // https://html.spec.whatwg.org/multipage/images.html#img-req-state
 | |
|     enum class State {
 | |
|         Unavailable,
 | |
|         PartiallyAvailable,
 | |
|         CompletelyAvailable,
 | |
|         Broken,
 | |
|     };
 | |
| 
 | |
|     bool is_available() const;
 | |
|     bool is_fetching() const;
 | |
| 
 | |
|     State state() const;
 | |
|     void set_state(State);
 | |
| 
 | |
|     AK::URL const& current_url() const;
 | |
|     void set_current_url(JS::Realm&, AK::URL);
 | |
| 
 | |
|     [[nodiscard]] JS::GCPtr<DecodedImageData> image_data() const;
 | |
|     void set_image_data(JS::GCPtr<DecodedImageData>);
 | |
| 
 | |
|     [[nodiscard]] float current_pixel_density() const { return m_current_pixel_density; }
 | |
|     void set_current_pixel_density(float density) { m_current_pixel_density = density; }
 | |
| 
 | |
|     [[nodiscard]] Optional<Gfx::FloatSize> const& preferred_density_corrected_dimensions() const { return m_preferred_density_corrected_dimensions; }
 | |
|     void set_preferred_density_corrected_dimensions(Optional<Gfx::FloatSize> dimensions) { m_preferred_density_corrected_dimensions = move(dimensions); }
 | |
| 
 | |
|     // https://html.spec.whatwg.org/multipage/images.html#prepare-an-image-for-presentation
 | |
|     void prepare_for_presentation(HTMLImageElement&);
 | |
| 
 | |
|     void fetch_image(JS::Realm&, JS::NonnullGCPtr<Fetch::Infrastructure::Request>);
 | |
|     void add_callbacks(Function<void()> on_finish, Function<void()> on_fail);
 | |
| 
 | |
|     SharedImageRequest const* shared_image_request() const { return m_shared_image_request; }
 | |
| 
 | |
|     virtual void visit_edges(JS::Cell::Visitor&) override;
 | |
| 
 | |
| private:
 | |
|     explicit ImageRequest(JS::NonnullGCPtr<Page>);
 | |
| 
 | |
|     JS::NonnullGCPtr<Page> m_page;
 | |
| 
 | |
|     // https://html.spec.whatwg.org/multipage/images.html#img-req-state
 | |
|     // An image request's state is initially unavailable.
 | |
|     State m_state { State::Unavailable };
 | |
| 
 | |
|     // https://html.spec.whatwg.org/multipage/images.html#img-req-url
 | |
|     // An image request's current URL is initially the empty string.
 | |
|     AK::URL m_current_url;
 | |
| 
 | |
|     // https://html.spec.whatwg.org/multipage/images.html#img-req-data
 | |
|     JS::GCPtr<DecodedImageData> m_image_data;
 | |
| 
 | |
|     // https://html.spec.whatwg.org/multipage/images.html#current-pixel-density
 | |
|     // Each image request has a current pixel density, which must initially be 1.
 | |
|     float m_current_pixel_density { 1 };
 | |
| 
 | |
|     // https://html.spec.whatwg.org/multipage/images.html#preferred-density-corrected-dimensions
 | |
|     // Each image request has preferred density-corrected dimensions,
 | |
|     // which is either a struct consisting of a width and a height or is null. It must initially be null.
 | |
|     Optional<Gfx::FloatSize> m_preferred_density_corrected_dimensions;
 | |
| 
 | |
|     JS::GCPtr<SharedImageRequest> m_shared_image_request;
 | |
| };
 | |
| 
 | |
| // https://html.spec.whatwg.org/multipage/images.html#abort-the-image-request
 | |
| void abort_the_image_request(JS::Realm&, ImageRequest*);
 | |
| 
 | |
| }
 |