mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2026-04-19 02:10:26 +00:00
d89f3fc5e6
Add a clang plugin check that flags GC::Cell subclasses (and their base classes within the Cell hierarchy) that have destructors with non-trivial bodies. Such logic should use Cell::finalize() instead. Add GC_ALLOW_CELL_DESTRUCTOR annotation macro for opting out in exceptional cases (currently only JS::Object). This prevents us from accidentally adding code in destructors that runs after something we're pointing to may have been destroyed. (This could become a problem when the garbage collector sweeps objects in an unfortunate order.) This new check uncovered a handful of bugs which are then also fixed in this commit. :^)
59 lines
1.5 KiB
C++
59 lines
1.5 KiB
C++
/*
|
|
* Copyright (c) 2020, Andreas Kling <andreas@ladybird.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <LibCore/Timer.h>
|
|
#include <LibJS/Runtime/Object.h>
|
|
#include <LibWeb/HTML/Timer.h>
|
|
#include <LibWeb/HTML/Window.h>
|
|
|
|
namespace Web::HTML {
|
|
|
|
GC_DEFINE_ALLOCATOR(Timer);
|
|
|
|
GC::Ref<Timer> Timer::create(JS::Object& window_or_worker_global_scope, i32 milliseconds, Function<void()> callback, i32 id, Repeating repeating)
|
|
{
|
|
return window_or_worker_global_scope.heap().allocate<Timer>(window_or_worker_global_scope, milliseconds, move(callback), id, repeating);
|
|
}
|
|
|
|
Timer::Timer(JS::Object& window_or_worker_global_scope, i32 milliseconds, Function<void()> callback, i32 id, Repeating repeating)
|
|
: m_window_or_worker_global_scope(window_or_worker_global_scope)
|
|
, m_id(id)
|
|
{
|
|
if (repeating == Repeating::Yes)
|
|
m_timer = Core::Timer::create_repeating(milliseconds, move(callback));
|
|
else
|
|
m_timer = Core::Timer::create_single_shot(milliseconds, move(callback));
|
|
}
|
|
|
|
void Timer::visit_edges(Cell::Visitor& visitor)
|
|
{
|
|
Base::visit_edges(visitor);
|
|
visitor.visit(m_window_or_worker_global_scope);
|
|
visitor.visit_possible_values(m_timer->on_timeout.raw_capture_range());
|
|
}
|
|
|
|
void Timer::finalize()
|
|
{
|
|
Base::finalize();
|
|
VERIFY(!m_timer->is_active());
|
|
}
|
|
|
|
void Timer::start()
|
|
{
|
|
m_timer->start();
|
|
}
|
|
|
|
void Timer::stop()
|
|
{
|
|
m_timer->stop();
|
|
}
|
|
|
|
void Timer::set_callback(Function<void()> callback)
|
|
{
|
|
m_timer->on_timeout = move(callback);
|
|
}
|
|
|
|
}
|