Stowage/ladybird
2
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2026-04-19 10:20:22 +00:00
Code Issues Projects Releases Packages Wiki Activity
ladybird/Tests/LibWeb/Layout/expected/grid
History
Jelle Raaijmakers 9e9db9a9dd LibWeb: Store correct text offsets in PaintableFragment 
Previously, we were collapsing whitespace in Layout::TextNode and then
passed the resulting string for further processing through ChunkIterator
-> InlineLevelIterator -> InlineFormattingContext -> LineBuilder ->
LineBoxFragment -> PaintableFragment. Our painting tree is where we deal
with things like range offsets into the underlying text nodes, but since
we modified the original string, the offsets were wrong.

This changes the way we generate fragments:

  * Layout::TextNode no longer collapses whitespace as part of its
    stored "text for rendering", but moves this logic to ChunkIterator
    which splits up this text into separate views whenever whitespace
    needs to be collapsed.

  * Layout::LineBox now only extends the last fragment if its end offset
    is equal to the new fragment's start offset. Otherwise, there's a
    gap caused by collapsing whitespace and we need to generate a
    separate fragment for that in order to have a correct start offset.

Some tests need new baselines because of the fixed start offsets.

Fixes #566.
2025-09-12 15:34:09 -04:00
..
1fr-1000px.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
abspos-item-aligned-center.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
abspos-item-contained-by-grid-area.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
abspos-item-with-grid-area-aligned-in-center.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
abspos-item-with-grid-area-and-percentage-size-2.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
abspos-item-with-grid-area-and-percentage-size.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
abspos-item-with-grid-area.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
abspos-item-with-padding.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
abspos-item-with-percentage-padding.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
abspos-item.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
abspos-placed-into-augmented-row-and-column.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
abspos-with-auto-column-placed-in-augmented-row.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
abspos-with-auto-row-and-column-contained-by-grid.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
abspos-with-auto-row-placed-in-augmented-column.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
abspos-with-grid-container-as-parent.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
align-content.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
align-items.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
align-self.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
all-implicit-rows.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
anonymous-inline-child.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
auto-fill-and-named-line-placement.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
auto-fill-rows.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
auto-fill.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
auto-fit-collapse-empty-tracks.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
auto-fit-empty-container.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
auto-fit-is-invalid-when-min-and-max-are-both-not-definite.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
auto-fit.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
auto-flow-column-spanning-item.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
auto-flow-column.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
auto-track-sizes.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
basic-2.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
basic.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
borders.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
calc-track-size.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
clamp-content-based-minimum-size-by-limited-max-track-size.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
column-1fr-1fr.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
column-auto-auto.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
columns-auto-fill-with-gap-2.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
columns-auto-fill-with-gap-3.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
columns-auto-fill-with-gap.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
container-max-width-max-content.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
container-min-height.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
css-calc-in-grid-position.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
define-area-using-line-names.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
different-column-sizes.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
distribute-extra-space-across-spanned-tracks.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
fit-content-1.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
fit-content-2.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
fit-content-3.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
fixed-tracks-followed-by-repeat-auto-fill.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
float-container-columns-1fr-1fr.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
floating-item.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
floating-table-wrapper-width.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
gfc-between-relpos-gfc-and-abspos-item.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
grid-area-non-token-parts-crash.txt LibWeb: Fix incorrect margin collapsing behavior [BFC] 2025-09-08 14:09:06 +02:00
grid-column-non-token-parts-crash.txt LibWeb: Fix incorrect margin collapsing behavior [BFC] 2025-09-08 14:09:06 +02:00
grid-container-min-height-border-box.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
grid-gap-1.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
grid-gap-2.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
grid-gap-3.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
grid-item-fixed-paddings.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
grid-item-fixed-size.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
grid-item-horizontal-margins-auto.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
grid-item-min-size.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
grid-item-percentage-margins.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
grid-item-percentage-width-2.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
grid-item-percentage-width.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
grid-item-vertical-padding-and-margin-percentages.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
grid-item-with-fit-content-width.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
grid-placement-shorthand-single-custom-ident.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
grid-row-height-affected-by-item-margins.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
grid-row-overflow-crash.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
grid-row-start-non-token-parts-crash.txt LibWeb: Fix incorrect margin collapsing behavior [BFC] 2025-09-08 14:09:06 +02:00
grid-shorthand-property.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
grid-span-4.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
grid-template-areas-basics.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
grid-template-columns-with-min-css-function.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
grid-template.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
grid-with-min-content-max-width.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
grow-beyond-limits.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
image-in-grid.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
image-with-percentage-width-and-auto-height.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
img-with-percentage-width-and-height.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
implicit-lines.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
inline-abspos-item.txt LibWeb: Store correct text offsets in PaintableFragment 2025-09-12 15:34:09 -04:00
inline-grid-simple.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
inline-item-with-overflow-hidden.txt LibWeb: Use 0 as min-content size for items with overflow:hidden [GFC] 2025-08-30 15:57:45 +02:00
intrinsic-sized-column.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
intrinsic-sized-grid-2.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
intrinsic-sized-grid.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
intrinsic-sizing-should-account-for-gaps.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
item-align-self-center-and-max-height.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
item-align-self-center-and-min-height.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
item-column-span-2.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
item-fit-content-width.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
item-max-width.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
item-min-max-percentage-width.txt LibWeb: Add ViewportPaintable to represent viewports in the paint tree 2023-08-20 05:02:59 +02:00
item-min-width.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
item-span-exceeds-columns-size.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
item-with-box-sizing-border-box.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
item-with-min-content-width.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
item-with-min-width-and-place-self-start.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
item-with-percentage-max-width.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
items-min-content-size-should-account-paddings.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
justify-content-cols.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
justify-content-fr.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
justify-content.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
justify-items.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
justify-self.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
justify-start-min-width.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
line-based-placement-named-lines-with-span-negative.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
line-based-placement-named-lines-with-span.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
line-based-with-repeat.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
line-placement-with-repeat.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
max-height-fit-content.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
max-width-grid-container-wrapper-in-max-content.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
min-height-from-text.txt LibWeb: Store correct text offsets in PaintableFragment 2025-09-12 15:34:09 -04:00
min-max-content.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
minmax-1.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
minmax-2.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
minmax-3.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
minmax-auto-track-definition.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
minmax-invalid-1.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
minmax-non-token-contents-crash.txt LibWeb: Fix incorrect margin collapsing behavior [BFC] 2025-09-08 14:09:06 +02:00
minmax-with-max-function-inside.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
minmax-with-percentage-max.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
negative-grid-item-column-index.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
order.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
place-items-center-nested-grids.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
place-items-center.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
place-self.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
placement-1.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
placement-2.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
placement-3.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
placement-4.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
placement-5.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
placement-6.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
placement-7.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
placement-8.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
placement-9.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
placement-10.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
placement-auto-negative.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
placement-using-named-tracks-1.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
placement-using-named-tracks-2.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
placement-using-named-tracks-3.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
relative-position-grid-item-with-percentage-insets.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
relpos-grid-item.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
repeat-auto-fit-fill-cannot-have-auto.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
repeat-non-token-contents-crash.txt LibWeb: Fix incorrect margin collapsing behavior [BFC] 2025-09-08 14:09:06 +02:00
repeat.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
replaced-box-with-percentage-max-width-2.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
replaced-box-with-percentage-max-width.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
replaced-item-1.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
replaced-item-2.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
restart-fr-algorithm-if-less-than-base-size.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
row-1fr.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
row-gaps-with-overflowing-spans-crash.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
row-height.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
row-span-2-maxcontent.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
row-span-2-mincontent.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
row-span-2-with-gaps.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
row-span-2.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
rows-1fr-1fr.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
should-not-cause-infinite-spinning-in-space-distribution.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
should-not-hang-in-size-distribution.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
stretch-auto-tracks.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
template-areas-1.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
template-areas-2.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
template-areas-3.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
template-lines-and-areas.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
track-size-calc-with-percentage.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
two-items-spanning-one-1fr-row.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
unresolvable-percentage-track.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
use-limited-contribution-if-container-has-intrinsic-available-size.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
valid-grid-areas-1.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00
vertical-margins-auto.txt LibWeb: Show inline positioning in layout tree dump 2025-08-27 11:53:45 +01:00