Add Prometheus metrics

Exposes a few metrics for Prometheus under /metrics if started with --prometheus.

Example:

    # HELP rest_server_blob_read_bytes_total Total number of bytes read from blobs
    # TYPE rest_server_blob_read_bytes_total counter
    rest_server_blob_read_bytes_total{repo="test",type="data"} 2.13557024e+09
    rest_server_blob_read_bytes_total{repo="test",type="index"} 1.198653e+06
    rest_server_blob_read_bytes_total{repo="test",type="keys"} 5388
    rest_server_blob_read_bytes_total{repo="test",type="locks"} 1975
    rest_server_blob_read_bytes_total{repo="test",type="snapshots"} 10018
    # HELP rest_server_blob_read_total Total number of blobs read
    # TYPE rest_server_blob_read_total counter
    rest_server_blob_read_total{repo="test",type="data"} 3985
    rest_server_blob_read_total{repo="test",type="index"} 21
    rest_server_blob_read_total{repo="test",type="keys"} 12
    rest_server_blob_read_total{repo="test",type="locks"} 12
    rest_server_blob_read_total{repo="test",type="snapshots"} 32
    # HELP rest_server_blob_write_bytes_total Total number of bytes written to blobs
    # TYPE rest_server_blob_write_bytes_total counter
    rest_server_blob_write_bytes_total{repo="test",type="data"} 1.063726179e+09
    rest_server_blob_write_bytes_total{repo="test",type="index"} 395586
    rest_server_blob_write_bytes_total{repo="test",type="locks"} 1975
    rest_server_blob_write_bytes_total{repo="test",type="snapshots"} 1933
    # HELP rest_server_blob_write_total Total number of blobs written
    # TYPE rest_server_blob_write_total counter
    rest_server_blob_write_total{repo="test",type="data"} 226
    rest_server_blob_write_total{repo="test",type="index"} 6
    rest_server_blob_write_total{repo="test",type="locks"} 12
    rest_server_blob_write_total{repo="test",type="snapshots"} 6
This commit is contained in:
Konrad Wojas 2017-10-24 23:03:50 +08:00 committed by Zlatko Čalušić
parent 526a2b3837
commit ca0e09261f
4 changed files with 69 additions and 3 deletions

View file

@ -30,6 +30,7 @@ func init() {
flags.StringVar(&restserver.Config.Path, "path", restserver.Config.Path, "data directory") flags.StringVar(&restserver.Config.Path, "path", restserver.Config.Path, "data directory")
flags.BoolVar(&restserver.Config.TLS, "tls", restserver.Config.TLS, "turn on TLS support") flags.BoolVar(&restserver.Config.TLS, "tls", restserver.Config.TLS, "turn on TLS support")
flags.BoolVar(&restserver.Config.AppendOnly, "append-only", restserver.Config.AppendOnly, "enable append only mode") flags.BoolVar(&restserver.Config.AppendOnly, "append-only", restserver.Config.AppendOnly, "enable append only mode")
flags.BoolVar(&restserver.Config.Prometheus, "prometheus", restserver.Config.AppendOnly, "enable Prometheus metrics")
} }
var version = "manually" var version = "manually"

View file

@ -13,9 +13,10 @@ import (
"path/filepath" "path/filepath"
"strings" "strings"
"time" "time"
"goji.io/middleware" "goji.io/middleware"
"goji.io/pat" "goji.io/pat"
"github.com/miolini/datacounter"
"github.com/prometheus/client_golang/prometheus"
) )
func isHashed(dir string) bool { func isHashed(dir string) bool {
@ -317,8 +318,15 @@ func GetBlob(w http.ResponseWriter, r *http.Request) {
return return
} }
http.ServeContent(w, r, "", time.Unix(0, 0), file) wc := datacounter.NewResponseWriterCounter(w)
http.ServeContent(wc, r, "", time.Unix(0, 0), file)
file.Close() file.Close()
if Config.Prometheus {
labels := prometheus.Labels{"repo": getRepo(r), "type": pat.Param(r, "type")}
metricBlobReadTotal.With(labels).Inc()
metricBlobReadBytesTotal.With(labels).Add(float64(wc.Count()))
}
} }
// SaveBlob saves a blob to the repository. // SaveBlob saves a blob to the repository.
@ -342,7 +350,8 @@ func SaveBlob(w http.ResponseWriter, r *http.Request) {
return return
} }
if _, err := io.Copy(tf, r.Body); err != nil { written, err := io.Copy(tf, r.Body)
if err != nil {
tf.Close() tf.Close()
os.Remove(path) os.Remove(path)
if Config.Debug { if Config.Debug {
@ -370,6 +379,12 @@ func SaveBlob(w http.ResponseWriter, r *http.Request) {
http.Error(w, http.StatusText(http.StatusInternalServerError), http.StatusInternalServerError) http.Error(w, http.StatusText(http.StatusInternalServerError), http.StatusInternalServerError)
return return
} }
if Config.Prometheus {
labels := prometheus.Labels{"repo": getRepo(r), "type": pat.Param(r, "type")}
metricBlobWriteTotal.With(labels).Inc()
metricBlobWriteBytesTotal.With(labels).Add(float64(written))
}
} }
// DeleteBlob deletes a blob from the repository. // DeleteBlob deletes a blob from the repository.

44
metrics.go Normal file
View file

@ -0,0 +1,44 @@
package restserver
import "github.com/prometheus/client_golang/prometheus"
var metricBlobWriteTotal = prometheus.NewCounterVec(
prometheus.CounterOpts{
Name: "rest_server_blob_write_total",
Help: "Total number of blobs written",
},
[]string{"repo", "type"},
)
var metricBlobWriteBytesTotal = prometheus.NewCounterVec(
prometheus.CounterOpts{
Name: "rest_server_blob_write_bytes_total",
Help: "Total number of bytes written to blobs",
},
[]string{"repo", "type"},
)
var metricBlobReadTotal = prometheus.NewCounterVec(
prometheus.CounterOpts{
Name: "rest_server_blob_read_total",
Help: "Total number of blobs read",
},
[]string{"repo", "type"},
)
var metricBlobReadBytesTotal = prometheus.NewCounterVec(
prometheus.CounterOpts{
Name: "rest_server_blob_read_bytes_total",
Help: "Total number of bytes read from blobs",
},
[]string{"repo", "type"},
)
func init() {
// These are always initialized, but only updated if Config.Prometheus is set
prometheus.MustRegister(metricBlobWriteTotal)
prometheus.MustRegister(metricBlobWriteBytesTotal)
prometheus.MustRegister(metricBlobReadTotal)
prometheus.MustRegister(metricBlobReadBytesTotal)
}

6
mux.go
View file

@ -8,6 +8,7 @@ import (
goji "goji.io" goji "goji.io"
"github.com/gorilla/handlers" "github.com/gorilla/handlers"
"github.com/prometheus/client_golang/prometheus/promhttp"
"goji.io/pat" "goji.io/pat"
) )
@ -19,6 +20,7 @@ var Config = struct {
CPUProfile string CPUProfile string
Debug bool Debug bool
AppendOnly bool AppendOnly bool
Prometheus bool
}{ }{
Path: "/tmp/restic", Path: "/tmp/restic",
Listen: ":8000", Listen: ":8000",
@ -53,6 +55,10 @@ func NewMux() *goji.Mux {
mux.Use(logHandler) mux.Use(logHandler)
} }
if Config.Prometheus {
mux.Handle(pat.Get("/metrics"), promhttp.Handler())
}
mux.HandleFunc(pat.Head("/config"), CheckConfig) mux.HandleFunc(pat.Head("/config"), CheckConfig)
mux.HandleFunc(pat.Head("/:repo/config"), CheckConfig) mux.HandleFunc(pat.Head("/:repo/config"), CheckConfig)
mux.HandleFunc(pat.Get("/config"), GetConfig) mux.HandleFunc(pat.Get("/config"), GetConfig)