Stowage/v86
2
0
Fork 0
mirror of https://github.com/copy/v86.git synced 2025-12-31 04:23:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

concatenate strings without using arrays

Browse source
This commit is contained in:
Christian Schnell 2025-09-08 22:09:12 +02:00 • committed by Fabian
parent 07270db5f4
commit 18ff2d85a1
2 changed files with 20 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/browser/dummy_screen.js
View file

@ -119,14 +119,14 @@ export function DummyScreenAdapter(options)
this.get_text_row = function(y)
{
const start = y * text_mode_width;
const end = start + text_mode_width;
const row = [];
for(let i = start; i < end; i++)
const begin = y * text_mode_width;
const end = begin + text_mode_width;
let row = "";
for(let i = begin; i < end; i++)
{
row.push(charmap[text_mode_data[i]]);
row += charmap[text_mode_data[i]];
}
return row.join("");
return row;
};
this.set_size_text(80, 25);

24
src/browser/screen.js
View file

@ -808,7 +808,8 @@ export function ScreenAdapter(options, screen_fill_buffer)
var blinking,
bg_color,
fg_color;
fg_color,
text;
row_element = text_screen.childNodes[row];
fragment = document.createElement("div");
@ -829,7 +830,7 @@ export function ScreenAdapter(options, screen_fill_buffer)
color_element.style.backgroundColor = number_as_color(bg_color);
color_element.style.color = number_as_color(fg_color);
const text = [];
text = "";
// put characters of the same color in one element
while(i < text_mode_width &&
@ -837,7 +838,10 @@ export function ScreenAdapter(options, screen_fill_buffer)
text_mode_data[offset + BG_COLOR_INDEX] === bg_color &&
text_mode_data[offset + FG_COLOR_INDEX] === fg_color)
{
text.push(charmap[text_mode_data[offset + CHARACTER_INDEX]]);
const chr = charmap[text_mode_data[offset + CHARACTER_INDEX]];
text += chr;
dbg_assert(chr);
i++;
offset += TEXT_BUF_COMPONENT_SIZE;
@ -860,7 +864,7 @@ export function ScreenAdapter(options, screen_fill_buffer)
}
}
color_element.textContent = text.join("");
color_element.textContent = text;
fragment.appendChild(color_element);
}
@ -917,14 +921,14 @@ export function ScreenAdapter(options, screen_fill_buffer)
this.get_text_row = function(y)
{
const start = y * text_mode_width * TEXT_BUF_COMPONENT_SIZE + CHARACTER_INDEX;
const end = start + text_mode_width * TEXT_BUF_COMPONENT_SIZE;
const row = [];
for(let i = start; i < end; i += TEXT_BUF_COMPONENT_SIZE)
const begin = y * text_mode_width * TEXT_BUF_COMPONENT_SIZE + CHARACTER_INDEX;
const end = begin + text_mode_width * TEXT_BUF_COMPONENT_SIZE;
let row = "";
for(let i = begin; i < end; i += TEXT_BUF_COMPONENT_SIZE)
{
row.push(charmap[text_mode_data[i]]);
row += charmap[text_mode_data[i]];
}
return row.join("");
return row;
};
this.init();