From fada8a0faba18a898e65a434faa44ccf124545ca Mon Sep 17 00:00:00 2001
From: Fabian <copy@copy.sh>
Date: Wed, 24 Jul 2024 16:12:32 +0200
Subject: [PATCH] no useless return

---
 eslint.config.mjs            | 1 +
 lib/9p.js                    | 1 -
 lib/filesystem.js            | 4 +---
 src/browser/fetch_network.js | 2 --
 src/sb16.js                  | 6 ++++--
 5 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/eslint.config.mjs b/eslint.config.mjs
index 9de0b52e..9d2a5e01 100644
--- a/eslint.config.mjs
+++ b/eslint.config.mjs
@@ -15,6 +15,7 @@ export default [
                 "catch": { "after": false },
             } }],
             "semi": "error",
+            "no-useless-return": "error",
             "eqeqeq": "error",
             //"no-var": "error",
             "radix": "error",
diff --git a/lib/9p.js b/lib/9p.js
index 9f481b66..27b39836 100644
--- a/lib/9p.js
+++ b/lib/9p.js
@@ -237,7 +237,6 @@ Virtio9p.prototype.BuildReply = function(id, tag, payloadsize) {
     //for(var i=0; i<payload.length; i++)
     //    this.replybuffer[7+i] = payload[i];
     this.replybuffersize = payloadsize+7;
-    return;
 };
 
 Virtio9p.prototype.SendError = function (tag, errormsg, errorcode) {
diff --git a/lib/filesystem.js b/lib/filesystem.js
index 974c0e39..4b605871 100644
--- a/lib/filesystem.js
+++ b/lib/filesystem.js
@@ -1264,13 +1264,11 @@ FS.prototype.DeleteNode = function(path) {
     if((this.inodes[ids.id].mode&S_IFMT) === S_IFREG){
         const ret = this.Unlink(ids.parentid, ids.name);
         dbg_assert(ret === 0, "Filesystem DeleteNode failed with error code: " + (-ret));
-        return;
     }
-    if((this.inodes[ids.id].mode&S_IFMT) === S_IFDIR){
+    else if((this.inodes[ids.id].mode&S_IFMT) === S_IFDIR){
         this.RecursiveDelete(path);
         const ret = this.Unlink(ids.parentid, ids.name);
         dbg_assert(ret === 0, "Filesystem DeleteNode failed with error code: " + (-ret));
-        return;
     }
 };
 
diff --git a/src/browser/fetch_network.js b/src/browser/fetch_network.js
index 501fa895..b627df4e 100644
--- a/src/browser/fetch_network.js
+++ b/src/browser/fetch_network.js
@@ -1051,7 +1051,6 @@ TCPConnection.prototype.connect = function() {
         syn: true,
     };
     this.net.receive(make_packet(reply));
-    return;
 };
 
 TCPConnection.prototype.accept = function(packet) {
@@ -1078,7 +1077,6 @@ TCPConnection.prototype.accept = function(packet) {
         ack: true
     };
     this.net.receive(make_packet(reply));
-    return;
 };
 
 TCPConnection.prototype.process = function(packet) {
diff --git a/src/sb16.js b/src/sb16.js
index f3dc9b53..43007644 100644
--- a/src/sb16.js
+++ b/src/sb16.js
@@ -1589,9 +1589,11 @@ register_fm_write([0x05], function(bits, register, address)
     {
         // No registers documented here.
         this.fm_default_write(bits, register, address);
-        return;
     }
-    // OPL3 Mode Enable
+    else
+    {
+        // OPL3 Mode Enable
+    }
 });
 
 register_fm_write([0x08], function(bits, register, address)