Stowage/browsertrix-crawler
2
0
Fork 0
mirror of https://github.com/webrecorder/browsertrix-crawler.git synced 2025-10-19 14:33:17 +00:00
Code Issues Projects Releases Packages Wiki Activity

don't exclude 204s

Browse source
This commit is contained in:
Ilya Kreymer 2024-01-17 13:28:14 -08:00
parent bc201be7f1
commit ea9639f0bd
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/util/recorder.ts
View file

@ -912,7 +912,7 @@ export class Recorder {
} }
async serializeToWARC(reqresp: RequestResponseInfo) { async serializeToWARC(reqresp: RequestResponseInfo) {
if (reqresp.shouldSkip()) { if (reqresp.shouldSkipSave()) {
const { url, method, status, payload } = reqresp; const { url, method, status, payload } = reqresp;
logNetwork("Skipping request/response", { logNetwork("Skipping request/response", {
url, url,

6
src/util/reqresp.ts
View file

@ -270,12 +270,12 @@ export class RequestResponseInfo {
return true; return true;
} }
shouldSkip() { shouldSkipSave() {
// skip OPTIONS/HEAD responses, and 304, 204 or 206 responses // skip OPTIONS/HEAD responses, and 304 or 206 responses
if ( if (
!this.payload || !this.payload ||
(this.method && ["OPTIONS", "HEAD"].includes(this.method)) || (this.method && ["OPTIONS", "HEAD"].includes(this.method)) ||
[204, 206, 304].includes(this.status) [206, 304].includes(this.status)
) { ) {
return true; return true;
} }