Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

[dev.simd] internal/cpu: add GFNI feature check

Browse source 
This CL amends HasAVX512 flag with GFNI check.

This is needed because our SIMD API supports Galois Field operations.

Change-Id: I3e957b7b2215d2b7b6b8a7a0ca3e2e60d453b2e5
Reviewed-on: https://go-review.googlesource.com/c/go/+/685295
Reviewed-by: David Chase <drchase@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This commit is contained in:
Junyang Shao 2025-07-01 18:00:33 +00:00
parent 0710cce6eb
commit 1ee72a15a3
4 changed files with 41 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/internal/cpu/cpu.go
View file

@ -31,6 +31,7 @@ var X86 struct {
HasADX bool HasADX bool
HasAVX bool HasAVX bool
HasAVX2 bool HasAVX2 bool
HasAVX512GFNI bool // Virtual feature: F+CD+BW+DQ+VL+GFNI
HasAVX512 bool // Virtual feature: F+CD+BW+DQ+VL HasAVX512 bool // Virtual feature: F+CD+BW+DQ+VL
HasAVX512F bool HasAVX512F bool
HasAVX512CD bool HasAVX512CD bool
@ -42,6 +43,7 @@ var X86 struct {
HasERMS bool HasERMS bool
HasFSRM bool HasFSRM bool
HasFMA bool HasFMA bool
HasGFNI bool
HasOSXSAVE bool HasOSXSAVE bool
HasPCLMULQDQ bool HasPCLMULQDQ bool
HasPOPCNT bool HasPOPCNT bool

5
src/internal/cpu/cpu_x86.go
View file

@ -22,6 +22,7 @@ const (
cpuid_SSE3 = 1 << 0 cpuid_SSE3 = 1 << 0
cpuid_PCLMULQDQ = 1 << 1 cpuid_PCLMULQDQ = 1 << 1
cpuid_SSSE3 = 1 << 9 cpuid_SSSE3 = 1 << 9
cpuid_GFNI = 1 << 8
cpuid_FMA = 1 << 12 cpuid_FMA = 1 << 12
cpuid_SSE41 = 1 << 19 cpuid_SSE41 = 1 << 19
cpuid_SSE42 = 1 << 20 cpuid_SSE42 = 1 << 20
@ -143,7 +144,7 @@ func doinit() {
return return
} }
_, ebx7, _, edx7 := cpuid(7, 0) _, ebx7, ecx7, edx7 := cpuid(7, 0)
X86.HasBMI1 = isSet(ebx7, cpuid_BMI1) X86.HasBMI1 = isSet(ebx7, cpuid_BMI1)
X86.HasAVX2 = isSet(ebx7, cpuid_AVX2) && osSupportsAVX X86.HasAVX2 = isSet(ebx7, cpuid_AVX2) && osSupportsAVX
X86.HasBMI2 = isSet(ebx7, cpuid_BMI2) X86.HasBMI2 = isSet(ebx7, cpuid_BMI2)
@ -160,6 +161,7 @@ func doinit() {
} }
X86.HasFSRM = isSet(edx7, cpuid_FSRM) X86.HasFSRM = isSet(edx7, cpuid_FSRM)
X86.HasGFNI = isSet(ecx7, cpuid_GFNI)
var maxExtendedInformation uint32 var maxExtendedInformation uint32
maxExtendedInformation, _, _, _ = cpuid(0x80000000, 0) maxExtendedInformation, _, _, _ = cpuid(0x80000000, 0)
@ -180,6 +182,7 @@ func doinit() {
// it. GOAMD64=v4 also implies exactly this set, and these are all // it. GOAMD64=v4 also implies exactly this set, and these are all
// included in AVX10.1. // included in AVX10.1.
X86.HasAVX512 = X86.HasAVX512F && X86.HasAVX512CD && X86.HasAVX512BW && X86.HasAVX512DQ && X86.HasAVX512VL X86.HasAVX512 = X86.HasAVX512F && X86.HasAVX512CD && X86.HasAVX512BW && X86.HasAVX512DQ && X86.HasAVX512VL
X86.HasAVX512GFNI = X86.HasAVX512 && X86.HasGFNI
} }
} }

5
src/simd/cpu.go
View file

@ -11,6 +11,11 @@ package simd
import "internal/cpu" import "internal/cpu"
// HasAVX512GFNI checks AVX512 CPU feature F+CD+BW+DQ+VL+GFNI.
func HasAVX512GFNI() bool {
return cpu.X86.HasAVX512GFNI
}
// HasAVX512 checks AVX512 CPU feature F+CD+BW+DQ+VL. // HasAVX512 checks AVX512 CPU feature F+CD+BW+DQ+VL.
func HasAVX512() bool { func HasAVX512() bool {
return cpu.X86.HasAVX512 return cpu.X86.HasAVX512

8
src/simd/simd_test.go
View file

@ -38,7 +38,7 @@ func TestType(t *testing.T) {
v.y = &y v.y = &y
sink = y sink = y
if !simd.HasAVX512() { if !simd.HasAVX512GFNI() {
t.Skip("Test requires HasAVX512, not available on this hardware") t.Skip("Test requires HasAVX512, not available on this hardware")
return return
} }
@ -97,7 +97,7 @@ func TestReflectMethod(t *testing.T) {
} }
func TestVectorConversion(t *testing.T) { func TestVectorConversion(t *testing.T) {
if !simd.HasAVX512() { if !simd.HasAVX512GFNI() {
t.Skip("Test requires HasAVX512, not available on this hardware") t.Skip("Test requires HasAVX512, not available on this hardware")
return return
} }
@ -115,7 +115,7 @@ func TestVectorConversion(t *testing.T) {
} }
func TestMaskConversion(t *testing.T) { func TestMaskConversion(t *testing.T) {
if !simd.HasAVX512() { if !simd.HasAVX512GFNI() {
t.Skip("Test requires HasAVX512, not available on this hardware") t.Skip("Test requires HasAVX512, not available on this hardware")
return return
} }
@ -144,7 +144,7 @@ func TestSub(t *testing.T) {
} }
func TestMaskedAdd(t *testing.T) { func TestMaskedAdd(t *testing.T) {
if !simd.HasAVX512() { if !simd.HasAVX512GFNI() {
t.Skip("Test requires HasAVX512, not available on this hardware") t.Skip("Test requires HasAVX512, not available on this hardware")
return return
} }