Stowage/go
2
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-12-08 06:10:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

remove bytes.Copy

Browse source 
replace all calls with calls to copy
use copy in regexp and bytes.Buffer

R=rsc
CC=golang-dev
https://golang.org/cl/157073
This commit is contained in:
Rob Pike 2009-11-18 15:24:24 -08:00
parent 093493c6a5
commit e70cedfaec
22 changed files with 147 additions and 218 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/pkg/xml/xml.go
View file

@ -65,19 +65,19 @@ type EndElement struct {
// the characters they represent.
type CharData []byte
func copy(b []byte) []byte {
func makeCopy(b []byte) []byte {
b1 := make([]byte, len(b));
bytes.Copy(b1, b);
copy(b1, b);
return b1;
}
func (c CharData) Copy() CharData { return CharData(copy(c)) }
func (c CharData) Copy() CharData { return CharData(makeCopy(c)) }
// A Comment represents an XML comment of the form <!--comment-->.
// The bytes do not include the <!-- and --> comment markers.
type Comment []byte
func (c Comment) Copy() Comment { return Comment(copy(c)) }
func (c Comment) Copy() Comment { return Comment(makeCopy(c)) }
// A ProcInst represents an XML processing instruction of the form <?target inst?>
type ProcInst struct {
@ -86,7 +86,7 @@ type ProcInst struct {
}
func (p ProcInst) Copy() ProcInst {
p.Inst = copy(p.Inst);
p.Inst = makeCopy(p.Inst);
return p;
}
@ -94,7 +94,7 @@ func (p ProcInst) Copy() ProcInst {
// The bytes do not include the <! and > markers.
type Directive []byte
func (d Directive) Copy() Directive { return Directive(copy(d)) }
func (d Directive) Copy() Directive { return Directive(makeCopy(d)) }
type readByter interface {
ReadByte() (b byte, err os.Error);